From 8977c1e5e01bf0c1de364cd2d30f237317b61b6a Mon Sep 17 00:00:00 2001 From: Morten Stenshorne Date: Fri, 17 Jul 2020 11:12:31 +0000 Subject: [PATCH] Bug 1651763 [wpt PR 24534] - [LayoutNG] Only spanner siblings are considered adjacent., a=testonly Automatic update from web-platform-tests [LayoutNG] Only spanner siblings are considered adjacent. The spec isn't crystal clear, but unconditionally considering spanners that are siblings of another spanner's ancestors as adjacent is definitely wrong. We need to resume column content layout inside the parent block of the spanner, since it may have a fixed block-size, block-end padding / border, or anything else that we'd just lose otherwise. This breaks one existing (non-WPT) test, but I'm not convinced that the test is valid. Filed crbug.com/1100849 for it. It also fixes 3 WPT tests. They were all quite complex, so I added a couple of simple ones, that demonstrate this fix more to the point. Bug: 829028 Change-Id: I9d55153f859dd84a5019e7d4dd09453f7f9ee1e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290150 Reviewed-by: Ian Kilpatrick Commit-Queue: Morten Stenshorne Cr-Commit-Position: refs/heads/master@{#786841} -- wpt-commits: 90c4db31dd07db9c6009cdbc0358f460099a15fb wpt-pr: 24534 --- .../css/css-multicol/non-adjacent-spanners-000.html | 11 +++++++++++ .../css/css-multicol/non-adjacent-spanners-001.html | 10 ++++++++++ 2 files changed, 21 insertions(+) create mode 100644 testing/web-platform/tests/css/css-multicol/non-adjacent-spanners-000.html create mode 100644 testing/web-platform/tests/css/css-multicol/non-adjacent-spanners-001.html diff --git a/testing/web-platform/tests/css/css-multicol/non-adjacent-spanners-000.html b/testing/web-platform/tests/css/css-multicol/non-adjacent-spanners-000.html new file mode 100644 index 000000000000..7e6ec67e298b --- /dev/null +++ b/testing/web-platform/tests/css/css-multicol/non-adjacent-spanners-000.html @@ -0,0 +1,11 @@ + + + + +

Test passes if there is a filled green square.

+
+
+
+
+
+
diff --git a/testing/web-platform/tests/css/css-multicol/non-adjacent-spanners-001.html b/testing/web-platform/tests/css/css-multicol/non-adjacent-spanners-001.html new file mode 100644 index 000000000000..fa8dfc8bcdf2 --- /dev/null +++ b/testing/web-platform/tests/css/css-multicol/non-adjacent-spanners-001.html @@ -0,0 +1,10 @@ + + + + +

Test passes if there is a filled green square and no red.

+
+
+
+
+