From 8a062555854064e1f4db20e265eafba930eed9f6 Mon Sep 17 00:00:00 2001 From: Boris Zbarsky Date: Thu, 9 Mar 2017 14:44:04 -0500 Subject: [PATCH] Bug 1343037 part 8. Get rid of nsIDOMHTMLInputElement's selectionDirection attribute. r=ehsan MozReview-Commit-ID: FNn4vVCM50s --- dom/html/HTMLInputElement.cpp | 20 ++----------------- .../html/nsIDOMHTMLInputElement.idl | 2 -- 2 files changed, 2 insertions(+), 20 deletions(-) diff --git a/dom/html/HTMLInputElement.cpp b/dom/html/HTMLInputElement.cpp index 74049cce5d0a..8d211759b32c 100644 --- a/dom/html/HTMLInputElement.cpp +++ b/dom/html/HTMLInputElement.cpp @@ -6455,7 +6455,7 @@ HTMLInputElement::SetSelectionStart(const Nullable& aSelectionStart, } nsAutoString direction; - aRv = GetSelectionDirection(direction); + GetSelectionDirection(direction, aRv); if (aRv.Failed()) { return; } @@ -6507,7 +6507,7 @@ HTMLInputElement::SetSelectionEnd(const Nullable& aSelectionEnd, } nsAutoString direction; - aRv = GetSelectionDirection(direction); + GetSelectionDirection(direction, aRv); if (aRv.Failed()) { return; } @@ -6596,14 +6596,6 @@ HTMLInputElement::GetSelectionDirection(nsAString& aDirection, ErrorResult& aRv) aRv.Throw(rv); } -NS_IMETHODIMP -HTMLInputElement::GetSelectionDirection(nsAString& aDirection) -{ - ErrorResult rv; - GetSelectionDirection(aDirection, rv); - return rv.StealNSResult(); -} - void HTMLInputElement::SetSelectionDirection(const nsAString& aDirection, ErrorResult& aRv) { @@ -6631,14 +6623,6 @@ HTMLInputElement::SetSelectionDirection(const nsAString& aDirection, ErrorResult } } -NS_IMETHODIMP -HTMLInputElement::SetSelectionDirection(const nsAString& aDirection) -{ - ErrorResult rv; - SetSelectionDirection(aDirection, rv); - return rv.StealNSResult(); -} - NS_IMETHODIMP HTMLInputElement::GetPhonetic(nsAString& aPhonetic) { diff --git a/dom/interfaces/html/nsIDOMHTMLInputElement.idl b/dom/interfaces/html/nsIDOMHTMLInputElement.idl index 9186f54b7d5d..50b1686d6f76 100644 --- a/dom/interfaces/html/nsIDOMHTMLInputElement.idl +++ b/dom/interfaces/html/nsIDOMHTMLInputElement.idl @@ -85,8 +85,6 @@ interface nsIDOMHTMLInputElement : nsISupports void select(); void setSelectionRange(in long selectionStart, in long selectionEnd, [optional] in DOMString direction); - attribute DOMString selectionDirection; - attribute DOMString useMap; readonly attribute nsIControllers controllers;