From 8abf7805e2470025339d005e28ee1842923897ae Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20B=C3=BCnzli?= Date: Sun, 7 Dec 2008 14:06:45 +0100 Subject: [PATCH] Bug 467828 - use cached favicons for the Recently Closed Tabs menu. r=gavin --- browser/base/content/browser.js | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/browser/base/content/browser.js b/browser/base/content/browser.js index 2c9314c4ce3a..1b4a418785c3 100644 --- a/browser/base/content/browser.js +++ b/browser/base/content/browser.js @@ -6204,8 +6204,13 @@ HistoryMenu.populateUndoSubmenu = function PHM_populateUndoSubmenu() { for (var i = 0; i < undoItems.length; i++) { var m = document.createElement("menuitem"); m.setAttribute("label", undoItems[i].title); - if (undoItems[i].image) - m.setAttribute("image", undoItems[i].image); + if (undoItems[i].image) { + let iconURL = undoItems[i].image; + // don't initiate a connection just to fetch a favicon (see bug 467828) + if (/^https?:/.test(iconURL)) + iconURL = "moz-anno:favicon:" + iconURL; + m.setAttribute("image", iconURL); + } m.setAttribute("class", "menuitem-iconic bookmark-item"); m.setAttribute("value", i); m.setAttribute("oncommand", "undoCloseTab(" + i + ");");