mozilla
/
gecko-dev
зеркало из https://github.com/mozilla/gecko-dev.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность

Bug 1343919 - Fix base URI in KeyframeEffect. r=birtles 

This is the only meaningful consumer of
ServoCSSParser::GetParsingEnvironment right now, but seems worth fixing
before other folks add more.

Differential Revision: https://phabricator.services.mozilla.com/D148145
This commit is contained in:
Emilio Cobos Álvarez 2022-06-04 12:49:12 +00:00
Родитель b24faeba30
Коммит 8adeaaa67f
2 изменённых файлов: 56 добавлений и 2 удалений
Показать статистику Скачать Patch файл Скачать Diff файл Показать все файлы Свернуть все файлы

3
layout/style/ServoCSSParser.cpp
Просмотреть файл

@ -73,9 +73,8 @@ already_AddRefed<URLExtraData> ServoCSSParser::GetURLExtraData(
nsCOMPtr<nsIReferrerInfo> referrerInfo =
ReferrerInfo::CreateForInternalCSSResources(aDocument);
// FIXME this is using the wrong base uri (bug 1343919)
RefPtr<URLExtraData> url = new URLExtraData(
aDocument->GetDocumentURI(), referrerInfo, aDocument->NodePrincipal());
aDocument->GetBaseURI(), referrerInfo, aDocument->NodePrincipal());
return url.forget();
}

55
testing/web-platform/tests/css/cssom/base-uri.html Normal file
Просмотреть файл

@ -0,0 +1,55 @@
<!doctype html>
<meta charset="utf-8">
<title>CSSOM base URI is the document's base URI</title>
<link rel="author" title="Emilio Cobos Álvarez" href="mailto:emilio@crisal.io">
<link rel="author" title="Mozilla" href="https://mozilla.org">
<link rel="help" href="https://html.spec.whatwg.org/#document-base-url">
<link rel="help" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1343919">
<base href="/non-existent-base/">
<script src='/resources/testharness.js'></script>
<script src='/resources/testharnessreport.js'></script>
<div id="target"></div>
<script>
const target = document.getElementById("target");
const kRelativeURI = "url(something.png)";
const kKeyframes = [
{ backgroundImage: kRelativeURI },
{ backgroundImage: kRelativeURI },
];
function assertBackground() {
const image = getComputedStyle(target).backgroundImage;
assert_true(image.includes("non-existent-base"), image);
}
function assertNoBackground() {
const image = getComputedStyle(target).backgroundImage;
assert_equals(image, "none");
}
promise_test(async function() {
target.style.backgroundImage = kRelativeURI;
assertBackground();
target.style.backgroundImage = "";
assertNoBackground();
}, "setProperty");
promise_test(async function() {
const keyframe = new KeyframeEffect(target, kKeyframes, 10000);
const animation = new Animation(keyframe, document.timeline);
animation.play();
await animation.ready;
assertBackground();
animation.cancel();
assertNoBackground();
}, "KeyframeEffect constructor");
promise_test(async function() {
const keyframe = new KeyframeEffect(target, [], 10000);
keyframe.setKeyframes(kKeyframes);
const animation = new Animation(keyframe, document.timeline);
animation.play();
await animation.ready;
assertBackground();
animation.cancel();
assertNoBackground();
}, "KeyframeEffect.setKeyframes");
</script>