Bug 1585760 - Store a flag in the TextureChild indicating use of the ImageBridge. r=sotaro

This avoids calling GetTextureForwarder during shutdown which may return a null pointer.

Differential Revision: https://phabricator.services.mozilla.com/D51615

--HG--
extra : moz-landing-system : lando

gfx/layers/client/TextureClient.cpp

@@ -117,7 +117,8 @@ class TextureChild final : PTextureChild {
         mMainThreadOnly(false),
         mIPCOpen(false),
         mOwnsTextureData(false),
-        mOwnerCalledDestroy(false) {}
+        mOwnerCalledDestroy(false),
+        mUsesImageBridge(false) {}
 
   mozilla::ipc::IPCResult Recv__delete__() override { return IPC_OK(); }
 
@@ -128,15 +129,13 @@ class TextureChild final : PTextureChild {
   bool IPCOpen() const { return mIPCOpen; }
 
   void Lock() const {
-    if (mCompositableForwarder &&
+    if (mUsesImageBridge) {
-        mCompositableForwarder->GetTextureForwarder()->UsesImageBridge()) {
       mLock.Enter();
     }
   }
 
   void Unlock() const {
-    if (mCompositableForwarder &&
+    if (mUsesImageBridge) {
-        mCompositableForwarder->GetTextureForwarder()->UsesImageBridge()) {
       mLock.Leave();
     }
   }
@@ -239,6 +238,7 @@ class TextureChild final : PTextureChild {
   bool mIPCOpen;
   bool mOwnsTextureData;
   bool mOwnerCalledDestroy;
+  bool mUsesImageBridge;
 
   friend class TextureClient;
   friend void DeallocateTextureClient(TextureDeallocParams params);
@@ -1055,6 +1055,7 @@ bool TextureClient::InitIPDLActor(CompositableForwarder* aForwarder) {
         }
       }
       mActor->mCompositableForwarder = aForwarder;
+      mActor->mUsesImageBridge = aForwarder->GetTextureForwarder()->UsesImageBridge();
     }
     return true;
   }