Bug 1493252 - Automatic profile viewing after mach talos-test doesn't work on my macOS machine. r=jmaher

--HG--
extra : rebase_source : 1e38f3d2880dd4a5ac3e5bd7527b2089f550a0a6
This commit is contained in:
Florin Strugariu 2018-10-08 17:31:07 +03:00
Родитель 32f1a0d3e4
Коммит 8c5bcd9209
2 изменённых файлов: 11 добавлений и 0 удалений

Просмотреть файл

@ -603,6 +603,11 @@ class Talos(TestingMixin, MercurialScript, TooltoolMixin,
'lib', 'lib',
os.path.basename(_python_interp), os.path.basename(_python_interp),
'site-packages') 'site-packages')
# if running gecko profiling install the requirements
if self.gecko_profile:
self._install_view_gecko_profile_req()
sys.path.append(_path) sys.path.append(_path)
return return
@ -632,6 +637,9 @@ class Talos(TestingMixin, MercurialScript, TooltoolMixin,
requirements=[os.path.join(self.talos_path, requirements=[os.path.join(self.talos_path,
'requirements.txt')] 'requirements.txt')]
) )
self._install_view_gecko_profile_req()
def _install_view_gecko_profile_req(self):
# if running locally and gecko profiing is on, we will be using the # if running locally and gecko profiing is on, we will be using the
# view-gecko-profile tool which has its own requirements too # view-gecko-profile tool which has its own requirements too
if self.gecko_profile and self.run_local: if self.gecko_profile and self.run_local:

Просмотреть файл

@ -350,6 +350,9 @@ def run_tests(config, browser_config):
def view_gecko_profile(ffox_bin): def view_gecko_profile(ffox_bin):
# automatically load the latest talos gecko-profile archive in perf-html.io # automatically load the latest talos gecko-profile archive in perf-html.io
if sys.platform.startswith('win') and not ffox_bin.endswith(".exe"):
ffox_bin = ffox_bin + ".exe"
if not os.path.exists(ffox_bin): if not os.path.exists(ffox_bin):
LOG.info("unable to find Firefox bin, cannot launch view-gecko-profile") LOG.info("unable to find Firefox bin, cannot launch view-gecko-profile")
return return