Bug 1559340 - Make sure NetworkConnectivityService::Init() only gets called once r=michal

Differential Revision: https://phabricator.services.mozilla.com/D35000

--HG--
extra : moz-landing-system : lando

netwerk/base/NetworkConnectivityService.h

@@ -25,13 +25,13 @@ class NetworkConnectivityService : public nsINetworkConnectivityService,
   NS_DECL_NSISTREAMLISTENER
   NS_DECL_NSIREQUESTOBSERVER
 
-  nsresult Init();
   static already_AddRefed<NetworkConnectivityService> GetSingleton();
 
  private:
   NetworkConnectivityService() = default;
   virtual ~NetworkConnectivityService() = default;
 
+  nsresult Init();
   // Calls all the check methods
   void PerformChecks();
 

netwerk/base/nsIOService.cpp

@@ -299,9 +299,9 @@ nsresult nsIOService::InitializeCaptivePortalService() {
         ->Initialize();
   }
 
+  // Instantiate and initialize the service
   RefPtr<NetworkConnectivityService> ncs =
       NetworkConnectivityService::GetSingleton();
-  ncs->Init();
 
   return NS_OK;
 }