From 8c7e4877d31cff1fb679aeecb4fcd4f2d00e7a04 Mon Sep 17 00:00:00 2001 From: Micah Tigley Date: Wed, 4 Dec 2019 00:44:23 +0000 Subject: [PATCH] Bug 1595800 - Part 3: Remove screen orientation attributes used for RDM from Document. r=smaug Depends on D55001 Differential Revision: https://phabricator.services.mozilla.com/D55002 --HG-- extra : moz-landing-system : lando --- dom/base/Document.cpp | 8 -------- dom/base/Document.h | 14 -------------- dom/webidl/Document.webidl | 10 ---------- 3 files changed, 32 deletions(-) diff --git a/dom/base/Document.cpp b/dom/base/Document.cpp index 127dbd5df685..1f98f8fa0181 100644 --- a/dom/base/Document.cpp +++ b/dom/base/Document.cpp @@ -1346,8 +1346,6 @@ Document::Document(const char* aContentType) mFlashClassification(FlashClassification::Unknown), mScrollAnchorAdjustmentLength(0), mScrollAnchorAdjustmentCount(0), - mCurrentOrientationAngle(0), - mCurrentOrientationType(OrientationType::Portrait_primary), mServoRestyleRootDirtyBits(0), mThrowOnDynamicMarkupInsertionCounter(0), mIgnoreOpensDuringUnloadCounter(0), @@ -13572,12 +13570,6 @@ bool Document::SetOrientationPendingPromise(Promise* aPromise) { return true; } -void Document::SetRDMPaneOrientation(OrientationType aType, uint16_t aAngle) { - if (GetBrowsingContext()->InRDMPane()) { - SetCurrentOrientation(aType, aAngle); - } -} - static void DispatchPointerLockChange(Document* aTarget) { if (!aTarget) { return; diff --git a/dom/base/Document.h b/dom/base/Document.h index 2ff664c96237..04dc98c4a8ce 100644 --- a/dom/base/Document.h +++ b/dom/base/Document.h @@ -2289,23 +2289,12 @@ class Document : public nsINode, // ScreenOrientation related APIs - void SetCurrentOrientation(OrientationType aType, uint16_t aAngle) { - mCurrentOrientationType = aType; - mCurrentOrientationAngle = aAngle; - } - - uint16_t CurrentOrientationAngle() const { return mCurrentOrientationAngle; } - OrientationType CurrentOrientationType() const { - return mCurrentOrientationType; - } void ClearOrientationPendingPromise(); bool SetOrientationPendingPromise(Promise* aPromise); Promise* GetOrientationPendingPromise() const { return mOrientationPendingPromise; } - void SetRDMPaneOrientation(OrientationType aType, uint16_t aAngle); - //---------------------------------------------------------------------- // Document notification API's @@ -5248,9 +5237,6 @@ class Document : public nsINode, // http://www.w3.org/TR/screen-orientation/ RefPtr mOrientationPendingPromise; - uint16_t mCurrentOrientationAngle; - OrientationType mCurrentOrientationType; - nsTArray> mInitializableFrameLoaders; nsTArray> mFrameLoaderFinalizers; RefPtr> mFrameLoaderRunner; diff --git a/dom/webidl/Document.webidl b/dom/webidl/Document.webidl index 6a8d4c590014..f9228873fc27 100644 --- a/dom/webidl/Document.webidl +++ b/dom/webidl/Document.webidl @@ -622,16 +622,6 @@ partial interface Document { readonly attribute FeaturePolicy featurePolicy; }; -/** - * Document extensions to support devtools. - */ -partial interface Document { - // Extension to give chrome JS the ability to set the window screen - // orientation while in RDM. - [ChromeOnly] - void setRDMPaneOrientation(OrientationType type, float rotationAngle); -}; - // Extension to give chrome JS the ability to specify a non-default keypress // event model. partial interface Document {