Bug 1637226 - Part 3: Revert the assertion in ClientSource.cpp back to MOZ_DIAGNOSTIC_ASSERT. r=dimi

Depends on D76732

Differential Revision: https://phabricator.services.mozilla.com/D76733

dom/clients/manager/ClientSource.cpp

@@ -262,9 +262,10 @@ nsresult ClientSource::WindowExecutionReady(nsPIDOMWindowInner* aInnerWindow) {
   // continue to inherit the SW as well.  We need to avoid triggering the
   // assertion in this corner case.
   if (mController.isSome()) {
-    MOZ_ASSERT(spec.LowerCaseEqualsLiteral("about:blank") ||
-               StringBeginsWith(spec, NS_LITERAL_CSTRING("blob:")) ||
-               StorageAllowedForWindow(aInnerWindow) == StorageAccess::eAllow);
+    MOZ_DIAGNOSTIC_ASSERT(spec.LowerCaseEqualsLiteral("about:blank") ||
+                          StringBeginsWith(spec, NS_LITERAL_CSTRING("blob:")) ||
+                          StorageAllowedForWindow(aInnerWindow) ==
+                              StorageAccess::eAllow);
   }
 
   nsPIDOMWindowOuter* outer = aInnerWindow->GetOuterWindow();