Bug 1338396 - LoginManagerContent: Use Date.now() instead of event.timeStamp until high-res timestamps are shipping. r=johannh

MozReview-Commit-ID: GS8DgpyYnxU

--HG--
extra : rebase_source : b6fb857bee06fb62e5e2e7f02aaebca9054b4fe4
This commit is contained in:
Matthew Noorenberghe 2017-02-13 23:49:16 +08:00
Родитель 07d305012c
Коммит 8d165c4d7f
1 изменённых файлов: 10 добавлений и 4 удалений

Просмотреть файл

@ -130,7 +130,9 @@ var observer = {
} }
case "contextmenu": { case "contextmenu": {
gLastContextMenuEventTimeStamp = aEvent.timeStamp; // Date.now() is used instead of event.timeStamp since
// dom.event.highrestimestamp.enabled isn't true on all channels yet.
gLastContextMenuEventTimeStamp = Date.now();
break; break;
} }
@ -578,11 +580,15 @@ var LoginManagerContent = {
* overlapping so we spin the event loop to see if a `contextmenu` event is coming next. If no * overlapping so we spin the event loop to see if a `contextmenu` event is coming next. If no
* `contextmenu` event was seen and the focused field is still focused by the form fill * `contextmenu` event was seen and the focused field is still focused by the form fill
* controller then show the autocomplete popup. * controller then show the autocomplete popup.
* Date.now() is used instead of event.timeStamp since dom.event.highrestimestamp.enabled isn't
* true on all channels yet.
*/ */
let timestamp = Date.now();
setTimeout(function maybeOpenAutocompleteAfterFocus() { setTimeout(function maybeOpenAutocompleteAfterFocus() {
// Even though the `focus` event happens first, its .timeStamp is greater in // Even though the `focus` event happens first in testing, I don't want to
// testing and I don't want to rely on that so the absolute value is used. // rely on that since it was supposedly in the opposite order before. Use
let timeDiff = Math.abs(gLastContextMenuEventTimeStamp - event.timeStamp); // the absolute value to handle both orders.
let timeDiff = Math.abs(gLastContextMenuEventTimeStamp - timestamp);
if (timeDiff < AUTOCOMPLETE_AFTER_CONTEXTMENU_THRESHOLD_MS) { if (timeDiff < AUTOCOMPLETE_AFTER_CONTEXTMENU_THRESHOLD_MS) {
log("Not opening autocomplete after focus since a context menu was opened within", log("Not opening autocomplete after focus since a context menu was opened within",
timeDiff, "ms"); timeDiff, "ms");