display save error on !success (rather than only for exceptions); bug 128367, r=adamlock, sr=kin; a=asa

editor/ui/composer/content/ComposerCommands.js

@@ -1243,9 +1243,6 @@ function SaveDocument(aSaveAs, aSaveCopy, aMimeType)
   }
   catch (e)
   {
-    var saveDocStr = GetString("SaveDocument");
-    var failedStr = GetString("SaveFileFailed");
-    AlertWithTitle(saveDocStr, failedStr);
     success = false;
   }
 
@@ -1260,6 +1257,12 @@ function SaveDocument(aSaveAs, aSaveCopy, aMimeType)
       SetSaveAndPublishUI(urlstring);
     } catch (e) {}
   }
+  else
+  {
+    var saveDocStr = GetString("SaveDocument");
+    var failedStr = GetString("SaveFileFailed");
+    AlertWithTitle(saveDocStr, failedStr);
+  }
   return success;
 }