Bug 578032 - Remove support for generic toolbar splitters, unintentionally added in bug 354048. r=enn

toolkit/content/tests/widgets/test_toolbar.xul

@@ -55,7 +55,6 @@
   <script type="text/javascript"><![CDATA[
     const SPACER = /^spacer\d+/;
     const SEPARATOR = /^separator\d+/;
-    const SPLITTER = /^splitter\d+/;
     const SPRING = /^spring\d+/;
 
     function testSet(aTb, aIDs, aResultIDs, aUseFixed) {
@@ -131,12 +130,11 @@
          [["spacer"],    [SPACER]],
          [["spring"],    [SPRING]],
          [["separator"], [SEPARATOR]],
-         [["splitter"],  [SPLITTER]],
          [["p11", "p11", "p12", "spacer", "p11"], ["p11", "p12", SPACER]],
-         [["splitter", "separator", "p11", "spring", "spacer"],
-          [SPLITTER, SEPARATOR, "p11", SPRING, SPACER]],
-         [["splitter", "spacer", "splitter", "p11", "spring", "spacer", "p12", "spring"],
-          [SPLITTER, SPACER, SPLITTER, "p11", SPRING, SPACER, "p12", SPRING]],
+         [["separator", "separator", "p11", "spring", "spacer"],
+          [SEPARATOR, SEPARATOR, "p11", SPRING, SPACER]],
+         [["separator", "spacer", "separator", "p11", "spring", "spacer", "p12", "spring"],
+          [SEPARATOR, SPACER, SEPARATOR, "p11", SPRING, SPACER, "p12", SPRING]],
          emptySet
       ];
 

toolkit/content/widgets/toolbar.xml

@@ -146,8 +146,6 @@
               return "spring";
             case "toolbarspacer":
               return "spacer";
-            case "splitter":
-              return "splitter";
             default:
               return aNode.id;
           }
@@ -260,11 +258,6 @@
                 if (aId == "spring")
                   newItem.flex = 1;
                 break;
-              case "splitter":
-                newItem = document.createElementNS(XUL_NS, "splitter");
-                newItem.id = aId + Date.now() + this.childNodes.length;
-                newItem.className = "toolbar-splitter";
-                break;
               default:
                 var toolbox = this.toolbox;
                 if (!toolbox)