Bug 1639716 - [devtools performance] Cleanup: pass the openAboutProfiling function from panel.js for more simplicity r=jdescottes

Differential Revision: https://phabricator.services.mozilla.com/D129421

devtools/client/performance-new/@types/perf.d.ts

@@ -18,7 +18,7 @@ export interface PanelWindow {
     perfFront: PerfFront,
     traits: RootTraits,
     pageContext: PageContext,
-    openAboutProfiling?: () => void
+    openAboutProfiling: () => void
   ): Promise<void>;
   gDestroy(): void;
   gIsPanelDestroyed?: boolean;

devtools/client/performance-new/initializer.js

@@ -94,20 +94,13 @@ const {
  *                              makes it possible to change some code path
  *                              depending on the server version.
  * @param {PageContext} pageContext - The context that the UI is being loaded in under.
- * @param {(() => void)?} openAboutProfiling - Optional call to open about:profiling
+ * @param {(() => void)} openAboutProfiling - Optional call to open about:profiling
  */
 async function gInit(perfFront, traits, pageContext, openAboutProfiling) {
   const store = createStore(reducers);
   const isSupportedPlatform = await perfFront.isSupportedPlatform();
   const supportedFeatures = await perfFront.getSupportedFeatures();
 
-  if (!openAboutProfiling) {
-    openAboutProfiling = () => {
-      const { openTrustedLink } = require("devtools/client/shared/link");
-      openTrustedLink("about:profiling", {});
-    };
-  }
-
   {
     // Expose the store as a global, for testing.
     const anyWindow = /** @type {any} */ (window);

devtools/client/performance-new/panel.js

@@ -68,10 +68,20 @@ class PerformancePanel {
       ),
     };
 
-    await this.panelWin.gInit(perfFront, traits, "devtools");
+    await this.panelWin.gInit(
+      perfFront,
+      traits,
+      "devtools",
+      this._openAboutProfiling
+    );
     return this;
   }
 
+  _openAboutProfiling() {
+    const { openTrustedLink } = require("devtools/client/shared/link");
+    openTrustedLink("about:profiling", {});
+  }
+
   // DevToolPanel API:
 
   /**