Bug 1801591 - Add eslint-plugin-eslint-plugin for linting our ESLint plugin rules, and upgrade most of node_modules. r=mossop

Depends on D168235

Differential Revision: https://phabricator.services.mozilla.com/D168236

devtools/server/actors/thread.js

@@ -1237,10 +1237,10 @@ class ThreadActor extends Actor {
               stepFrame.onStep = onStep;
             }
           }
-        // eslint-disable no-fallthrough
+        // eslint-disable-next-line no-fallthrough
         case "finish":
           stepFrame.onStep = createStepForReactionTracking(stepFrame.onStep);
-        // eslint-disable no-fallthrough
+        // eslint-disable-next-line no-fallthrough
         case "restart":
           stepFrame.onPop = onPop;
           break;

package.json

@@ -4,20 +4,21 @@
   "repository": {},
   "license": "MPL-2.0",
   "devDependencies": {
-    "@babel/core": "7.20.5",
+    "@babel/core": "7.20.12",
     "@babel/eslint-parser": "7.19.1",
     "@babel/eslint-plugin": "7.19.1",
     "@babel/plugin-syntax-jsx": "7.18.6",
     "@microsoft/eslint-plugin-sdl": "github:mozfreddyb/eslint-plugin-sdl#17b22cd527682108af7a1a4edacf69cb7a9b4a06",
-    "eslint": "8.29.0",
-    "eslint-config-prettier": "8.5.0",
+    "eslint": "8.33.0",
+    "eslint-config-prettier": "8.6.0",
+    "eslint-plugin-eslint-plugin": "5.0.8",
     "eslint-plugin-fetch-options": "0.0.5",
     "eslint-plugin-file-header": "0.0.1",
     "eslint-plugin-html": "7.1.0",
-    "eslint-plugin-import": "2.26.0",
+    "eslint-plugin-import": "2.27.5",
     "eslint-plugin-jest": "23.20.0",
-    "eslint-plugin-jsdoc": "39.6.4",
-    "eslint-plugin-jsx-a11y": "6.6.1",
+    "eslint-plugin-jsdoc": "39.7.4",
+    "eslint-plugin-jsx-a11y": "6.7.1",
     "eslint-plugin-mozilla": "file:tools/lint/eslint/eslint-plugin-mozilla",
     "eslint-plugin-no-unsanitized": "4.0.2",
     "eslint-plugin-prettier": "3.4.0",

tools/lint/eslint/.eslintrc.js

@@ -5,6 +5,8 @@
 "use strict";
 
 module.exports = {
+  plugins: ["eslint-plugin"],
+  extends: ["plugin:eslint-plugin/recommended"],
   // eslint-plugin-mozilla runs under node, so we need a more restrictive
   // environment / parser setup here than the rest of mozilla-central.
   env: {
@@ -23,5 +25,6 @@ module.exports = {
     "no-undef-init": "error",
     "one-var": ["error", "never"],
     strict: ["error", "global"],
+    "eslint-plugin/prefer-message-ids": "off",
   },
 };

tools/lint/eslint/eslint-plugin-mozilla/manifest.tt

@@ -1,9 +1,9 @@
 [
   {
     "filename": "eslint-plugin-mozilla.tar.gz",
-    "size": 11340023,
+    "size": 11475311,
     "algorithm": "sha512",
-    "digest": "f98c6d1d1065cd6ea7ec8878be5eefef0510f02f6bb389b70c29b753b54067e92a0ec2e3e9f53b3a107e3e2facfd3a698caf79310dcb452bbf03b22a35472a4f",
+    "digest": "309cab6d8a66533505decc708d1f0a6f65c1a639c4c2c740b0c0649d766efe8206c0b51abaa59ae990c201dc039ac8b0295987f2862ac5b568b4e8e9341300ca",
     "unpack": true,
     "visibility": "public"
   }

tools/lint/eslint/eslint-plugin-mozilla/package.json

@@ -20,7 +20,7 @@
   "author": "Mike Ratcliffe",
   "main": "lib/index.js",
   "dependencies": {
-    "@babel/core": "^7.20.5",
+    "@babel/core": "^7.20.12",
     "@babel/eslint-parser": "^7.19.1",
     "eslint-scope": "^7.1.1",
     "eslint-visitor-keys": "^3.3.0",
@@ -29,8 +29,8 @@
     "multi-ini": "^2.3.2"
   },
   "devDependencies": {
-    "eslint": "8.29.0",
-    "mocha": "10.1.0"
+    "eslint": "8.33.0",
+    "mocha": "10.2.0"
   },
   "peerDependencies": {
     "@microsoft/eslint-plugin-sdl": "github:mozfreddyb/eslint-plugin-sdl#17b22cd527682108af7a1a4edacf69cb7a9b4a06",

tools/lint/eslint/manifest.tt

@@ -1,9 +1,9 @@
 [
   {
     "filename": "eslint.tar.gz",
-    "size": 28525866,
+    "size": 28539167,
     "algorithm": "sha512",
-    "digest": "969433e493a6f5dacff4957478c4203b4a90abe7db762c890231fba16614e3eb3a7d1a956542a465bd2eefb996214fa176e95c885bcfce4daa1af963ab879aa1",
+    "digest": "25d3154ec47678bf1943822a446dd3c4e775f5df58c0197daef0d5da807b9912f6d7bbde8f3bf538d57057b0b9412df00275cddea8b040a8e163490fe157ab93",
     "unpack": true,
     "visibility": "public"
   }