Bug 1536556 - Replace new Error(Cr.ERROR) with new Component.Exception. r=mossop

Passing Cr.ERROR to an Error constructor is incorrect since it just sets the
message of the error to the integer value of the Cr.ERROR. Cr.ERRORs need to be
used as the second argument to Component.Exception to correctly construct an
Exception object with its result property set to the Cr.ERROR value.

This was done automatically by an expansion of the new
mozilla/no-throw-cr-literal eslint rule that will be introduced in the next
commit.

Differential Revision: https://phabricator.services.mozilla.com/D28075

security/manager/ssl/tests/unit/test_certDB_import.js

@@ -52,7 +52,7 @@ const gInterfaceRequestor = {
       return this;
     }
 
-    throw new Error(Cr.NS_ERROR_NO_INTERFACE);
+    throw Components.Exception("", Cr.NS_ERROR_NO_INTERFACE);
   },
 };
 

security/manager/ssl/tests/unit/test_certDB_import_with_master_password.js

@@ -72,7 +72,7 @@ var gMockPrompter = {
       return this;
     }
 
-    throw new Error(Cr.NS_ERROR_NO_INTERFACE);
+    throw Components.Exception("", Cr.NS_ERROR_NO_INTERFACE);
   },
 };
 

security/manager/ssl/tests/unit/test_pkcs11_safe_mode.js

@@ -25,7 +25,7 @@ function run_test() {
   let xulRuntimeFactory = {
     createInstance(outer, iid) {
       if (outer != null) {
-        throw new Error(Cr.NS_ERROR_NO_AGGREGATION);
+        throw Components.Exception("", Cr.NS_ERROR_NO_AGGREGATION);
       }
       return xulRuntime.QueryInterface(iid);
     },

taskcluster/docker/periodic-updates/scripts/getHSTSPreloadList.js

@@ -175,7 +175,7 @@ function RedirectAndAuthStopper() {}
 RedirectAndAuthStopper.prototype = {
   // nsIChannelEventSink
   asyncOnChannelRedirect(oldChannel, newChannel, flags, callback) {
-    throw new Error(Cr.NS_ERROR_ENTITY_CHANGED);
+    throw Components.Exception("", Cr.NS_ERROR_ENTITY_CHANGED);
   },
 
   // nsIAuthPrompt2
@@ -184,7 +184,7 @@ RedirectAndAuthStopper.prototype = {
   },
 
   asyncPromptAuth(channel, callback, context, level, authInfo) {
-    throw new Error(Cr.NS_ERROR_NOT_IMPLEMENTED);
+    throw Components.Exception("", Cr.NS_ERROR_NOT_IMPLEMENTED);
   },
 
   getInterface(iid) {