Bug 1613985 - Use default for equivalent-to-default constructors/destructors in security. r=rrelyea

Differential Revision: https://phabricator.services.mozilla.com/D65499

--HG--
extra : moz-landing-system : lando

security/apps/AppSignatureVerification.cpp

@@ -806,7 +806,7 @@ class CoseVerificationContext {
  public:
   explicit CoseVerificationContext(AppTrustedRoot aTrustedRoot)
       : mTrustedRoot(aTrustedRoot), mCertDER(nullptr), mCertDERLen(0) {}
-  ~CoseVerificationContext() {}
+  ~CoseVerificationContext() = default;
 
   AppTrustedRoot GetTrustedRoot() { return mTrustedRoot; }
   nsresult SetCert(SECItem* aCertDER) {
@@ -1041,7 +1041,7 @@ class SignaturePolicy {
       mSHA256Allowed = true;
     }
   }
-  ~SignaturePolicy() {}
+  ~SignaturePolicy() = default;
   bool ProcessCOSE() { return mProcessCose; }
   bool COSERequired() { return mCoseRequired; }
   bool PK7Required() { return mPK7Required; }

security/certverifier/CertVerifier.cpp

@@ -128,7 +128,7 @@ CertVerifier::CertVerifier(OcspDownloadConfig odc, OcspStrictConfig osc,
   }
 }
 
-CertVerifier::~CertVerifier() {}
+CertVerifier::~CertVerifier() = default;
 
 Result IsCertChainRootBuiltInRoot(const UniqueCERTCertList& chain,
                                   bool& result) {

security/manager/pki/nsNSSDialogs.cpp

@@ -30,9 +30,9 @@
 
 #define PIPSTRING_BUNDLE_URL "chrome://pippki/locale/pippki.properties"
 
-nsNSSDialogs::nsNSSDialogs() {}
+nsNSSDialogs::nsNSSDialogs() = default;
 
-nsNSSDialogs::~nsNSSDialogs() {}
+nsNSSDialogs::~nsNSSDialogs() = default;
 
 NS_IMPL_ISUPPORTS(nsNSSDialogs, nsITokenPasswordDialogs, nsICertificateDialogs,
                   nsIClientAuthDialogs, nsITokenDialogs)

security/manager/ssl/CryptoTask.h

@@ -28,7 +28,7 @@ class CryptoTask : public Runnable {
  protected:
   CryptoTask() : Runnable("CryptoTask"), mRv(NS_ERROR_NOT_INITIALIZED) {}
 
-  virtual ~CryptoTask() {}
+  virtual ~CryptoTask() = default;
 
   /**
    * Called on a background thread (never the main thread). Its result will be

security/manager/ssl/DataStorage.cpp

@@ -64,7 +64,7 @@ class DataStorageSharedThread final {
   static nsresult Shutdown();
   static nsresult Dispatch(nsIRunnable* event);
 
-  virtual ~DataStorageSharedThread() {}
+  virtual ~DataStorageSharedThread() = default;
 
  private:
   DataStorageSharedThread() : mThread(nullptr) {}

security/manager/ssl/LibSecret.cpp

@@ -189,7 +189,7 @@ typedef std::unique_ptr<SecretCollection, ScopedMaybeDelete<SecretCollection>>
 typedef std::unique_ptr<SecretService, ScopedMaybeDelete<SecretService>>
     ScopedSecretService;
 
-LibSecret::LibSecret() {}
+LibSecret::LibSecret() = default;
 
 LibSecret::~LibSecret() {
   MOZ_ASSERT(NS_IsMainThread());

security/manager/ssl/LocalCertService.cpp

@@ -345,9 +345,9 @@ class LocalCertRemoveTask final : public LocalCertTask {
 
 NS_IMPL_ISUPPORTS(LocalCertService, nsILocalCertService)
 
-LocalCertService::LocalCertService() {}
+LocalCertService::LocalCertService() = default;
 
-LocalCertService::~LocalCertService() {}
+LocalCertService::~LocalCertService() = default;
 
 nsresult LocalCertService::LoginToKeySlot() {
   nsresult rv;

security/manager/ssl/NSSErrorsService.cpp

@@ -33,7 +33,7 @@ static bool IsPSMError(PRErrorCode error) {
 
 NS_IMPL_ISUPPORTS(NSSErrorsService, nsINSSErrorsService)
 
-NSSErrorsService::~NSSErrorsService() {}
+NSSErrorsService::~NSSErrorsService() = default;
 
 nsresult NSSErrorsService::Init() {
   nsresult rv;

security/manager/ssl/NSSKeyStore.cpp

@@ -31,7 +31,7 @@ NSSKeyStore::NSSKeyStore() {
   Unused << EnsureNSSInitializedChromeOrContent();
   Unused << InitToken();
 }
-NSSKeyStore::~NSSKeyStore() {}
+NSSKeyStore::~NSSKeyStore() = default;
 
 nsresult NSSKeyStore::InitToken() {
   if (!mSlot) {

security/manager/ssl/OSKeyStore.h

@@ -34,7 +34,7 @@ class AbstractOSKeyStore {
   virtual nsresult Lock() = 0;
   // Unlock the key store.
   virtual nsresult Unlock() = 0;
-  virtual ~AbstractOSKeyStore() {}
+  virtual ~AbstractOSKeyStore() = default;
 
   // Returns true if the secret with the given label is available in the key
   // store, false otherwise.

security/manager/ssl/PKCS11ModuleDB.h

@@ -20,13 +20,13 @@ namespace psm {
 
 class PKCS11ModuleDB : public nsIPKCS11ModuleDB {
  public:
-  PKCS11ModuleDB() {}
+  PKCS11ModuleDB() = default;
 
   NS_DECL_ISUPPORTS
   NS_DECL_NSIPKCS11MODULEDB
 
  protected:
-  virtual ~PKCS11ModuleDB() {}
+  virtual ~PKCS11ModuleDB() = default;
 };
 
 }  // namespace psm

security/manager/ssl/PSMContentListener.cpp

@@ -97,7 +97,7 @@ int64_t ComputeContentLength(nsIRequest* request) {
 PSMContentStreamListener::PSMContentStreamListener(uint32_t type)
     : mType(type) {}
 
-PSMContentStreamListener::~PSMContentStreamListener() {}
+PSMContentStreamListener::~PSMContentStreamListener() = default;
 
 NS_IMPL_ISUPPORTS(PSMContentStreamListener, nsIStreamListener,
                   nsIRequestObserver)
@@ -197,7 +197,7 @@ void PSMContentStreamListener::ImportCertificate() {
 PSMContentDownloaderParent::PSMContentDownloaderParent(uint32_t type)
     : PSMContentStreamListener(type), mIPCOpen(true) {}
 
-PSMContentDownloaderParent::~PSMContentDownloaderParent() {}
+PSMContentDownloaderParent::~PSMContentDownloaderParent() = default;
 
 mozilla::ipc::IPCResult PSMContentDownloaderParent::RecvOnStartRequest(
     const uint32_t& contentLength) {
@@ -256,9 +256,9 @@ void PSMContentDownloaderParent::ActorDestroy(ActorDestroyReason why) {
 
 NS_IMPL_ISUPPORTS(PSMContentDownloaderChild, nsIStreamListener)
 
-PSMContentDownloaderChild::PSMContentDownloaderChild() {}
+PSMContentDownloaderChild::PSMContentDownloaderChild() = default;
 
-PSMContentDownloaderChild::~PSMContentDownloaderChild() {}
+PSMContentDownloaderChild::~PSMContentDownloaderChild() = default;
 
 NS_IMETHODIMP
 PSMContentDownloaderChild::OnStartRequest(nsIRequest* request) {
@@ -317,7 +317,7 @@ PSMContentListener::PSMContentListener() {
   mParentContentListener = nullptr;
 }
 
-PSMContentListener::~PSMContentListener() {}
+PSMContentListener::~PSMContentListener() = default;
 
 nsresult PSMContentListener::init() { return NS_OK; }
 

security/manager/ssl/SecretDecoderRing.h

@@ -24,10 +24,10 @@ class SecretDecoderRing : public nsISecretDecoderRing {
   NS_DECL_THREADSAFE_ISUPPORTS
   NS_DECL_NSISECRETDECODERRING
 
-  SecretDecoderRing() {}
+  SecretDecoderRing() = default;
 
  protected:
-  virtual ~SecretDecoderRing() {}
+  virtual ~SecretDecoderRing() = default;
 
  private:
   nsresult Encrypt(const nsACString& data, /*out*/ nsACString& result);

security/manager/ssl/SharedSSLState.cpp

@@ -95,7 +95,7 @@ class PrivateBrowsingObserver : public nsIObserver {
   explicit PrivateBrowsingObserver(SharedSSLState* aOwner) : mOwner(aOwner) {}
 
  protected:
-  virtual ~PrivateBrowsingObserver() {}
+  virtual ~PrivateBrowsingObserver() = default;
 
  private:
   SharedSSLState* mOwner;
@@ -126,7 +126,7 @@ SharedSSLState::SharedSSLState(uint32_t aTlsFlags)
   mIOLayerHelpers.Init();
 }
 
-SharedSSLState::~SharedSSLState() {}
+SharedSSLState::~SharedSSLState() = default;
 
 void SharedSSLState::NotePrivateBrowsingStatus() {
   MOZ_ASSERT(NS_IsMainThread(), "Not on main thread");

security/manager/ssl/TransportSecurityInfo.h

@@ -36,7 +36,7 @@ class TransportSecurityInfo : public nsITransportSecurityInfo,
                               public nsISerializable,
                               public nsIClassInfo {
  protected:
-  virtual ~TransportSecurityInfo() {}
+  virtual ~TransportSecurityInfo() = default;
 
  public:
   TransportSecurityInfo();

security/manager/ssl/nsCertOverrideService.cpp

@@ -88,7 +88,7 @@ NS_IMPL_ISUPPORTS(nsCertOverrideService, nsICertOverrideService, nsIObserver,
 nsCertOverrideService::nsCertOverrideService()
     : mDisableAllSecurityCheck(false), mMutex("nsCertOverrideService.mutex") {}
 
-nsCertOverrideService::~nsCertOverrideService() {}
+nsCertOverrideService::~nsCertOverrideService() = default;
 
 nsresult nsCertOverrideService::Init() {
   if (!NS_IsMainThread()) {

security/manager/ssl/nsCertOverrideService.h

@@ -32,19 +32,6 @@ class nsCertOverride {
   nsCertOverride()
       : mPort(-1), mIsTemporary(false), mOverrideBits(OverrideBits::None) {}
 
-  nsCertOverride(const nsCertOverride& other) { this->operator=(other); }
-
-  nsCertOverride& operator=(const nsCertOverride& other) {
-    mAsciiHost = other.mAsciiHost;
-    mPort = other.mPort;
-    mIsTemporary = other.mIsTemporary;
-    mFingerprint = other.mFingerprint;
-    mOverrideBits = other.mOverrideBits;
-    mDBKey = other.mDBKey;
-    mCert = other.mCert;
-    return *this;
-  }
-
   nsCString mAsciiHost;
   int32_t mPort;
   bool mIsTemporary;  // true: session only, false: stored on disk
@@ -74,7 +61,7 @@ class nsCertOverrideEntry final : public PLDHashEntryHdr {
         mSettings(std::move(toMove.mSettings)),
         mHostWithPort(std::move(toMove.mHostWithPort)) {}
 
-  ~nsCertOverrideEntry() {}
+  ~nsCertOverrideEntry() = default;
 
   KeyType GetKey() const { return HostWithPortPtr(); }
 

security/manager/ssl/nsCertTree.cpp

@@ -100,7 +100,7 @@ nsCertTreeDispInfo::nsCertTreeDispInfo(nsCertTreeDispInfo& other) {
   mCert = other.mCert;
 }
 
-nsCertTreeDispInfo::~nsCertTreeDispInfo() {}
+nsCertTreeDispInfo::~nsCertTreeDispInfo() = default;
 
 NS_IMETHODIMP
 nsCertTreeDispInfo::GetCert(nsIX509Cert** _cert) {

security/manager/ssl/nsCertTree.h

@@ -52,7 +52,7 @@ struct CompareCacheHashEntryPtr : PLDHashEntryHdr {
 
 class nsCertAddonInfo final : public nsISupports {
  private:
-  ~nsCertAddonInfo() {}
+  ~nsCertAddonInfo() = default;
 
  public:
   NS_DECL_ISUPPORTS

security/manager/ssl/nsClientAuthRemember.h

@@ -27,19 +27,6 @@ using mozilla::OriginAttributes;
 
 class nsClientAuthRemember {
  public:
-  nsClientAuthRemember() {}
-
-  nsClientAuthRemember(const nsClientAuthRemember& aOther) {
-    this->operator=(aOther);
-  }
-
-  nsClientAuthRemember& operator=(const nsClientAuthRemember& aOther) {
-    mAsciiHost = aOther.mAsciiHost;
-    mFingerprint = aOther.mFingerprint;
-    mDBKey = aOther.mDBKey;
-    return *this;
-  }
-
   nsCString mAsciiHost;
   nsCString mFingerprint;
   nsCString mDBKey;
@@ -60,7 +47,7 @@ class nsClientAuthRememberEntry final : public PLDHashEntryHdr {
         mSettings(std::move(aToMove.mSettings)),
         mEntryKey(std::move(aToMove.mEntryKey)) {}
 
-  ~nsClientAuthRememberEntry() {}
+  ~nsClientAuthRememberEntry() = default;
 
   KeyType GetKey() const { return EntryKeyPtr(); }
 

security/manager/ssl/nsCryptoHash.h

@@ -36,7 +36,7 @@ class nsCryptoHash final : public nsICryptoHash {
   nsCryptoHash();
 
  private:
-  virtual ~nsCryptoHash() {}
+  virtual ~nsCryptoHash() = default;
 
   mozilla::UniqueHASHContext mHashContext;
   bool mInitialized;
@@ -50,7 +50,7 @@ class nsCryptoHMAC : public nsICryptoHMAC {
   nsCryptoHMAC();
 
  private:
-  virtual ~nsCryptoHMAC() {}
+  virtual ~nsCryptoHMAC() = default;
 
   mozilla::UniquePK11Context mHMACContext;
 };

security/manager/ssl/nsKeyModule.h

@@ -34,7 +34,7 @@ class nsKeyObject final : public nsIKeyObject {
   NS_DECL_NSIKEYOBJECT
 
  private:
-  ~nsKeyObject() {}
+  ~nsKeyObject() = default;
 
   // Disallow copy constructor
   nsKeyObject(nsKeyObject&);
@@ -44,13 +44,13 @@ class nsKeyObject final : public nsIKeyObject {
 
 class nsKeyObjectFactory final : public nsIKeyObjectFactory {
  public:
-  nsKeyObjectFactory() {}
+  nsKeyObjectFactory() = default;
 
   NS_DECL_THREADSAFE_ISUPPORTS
   NS_DECL_NSIKEYOBJECTFACTORY
 
  private:
-  ~nsKeyObjectFactory() {}
+  ~nsKeyObjectFactory() = default;
 
   // Disallow copy constructor
   nsKeyObjectFactory(nsKeyObjectFactory&);

security/manager/ssl/nsNSSCertTrust.cpp

@@ -37,7 +37,7 @@ nsNSSCertTrust::nsNSSCertTrust(CERTCertTrust* t) {
     memset(&mTrust, 0, sizeof(CERTCertTrust));
 }
 
-nsNSSCertTrust::~nsNSSCertTrust() {}
+nsNSSCertTrust::~nsNSSCertTrust() = default;
 
 void nsNSSCertTrust::SetSSLTrust(bool peer, bool tPeer, bool ca, bool tCA,
                                  bool tClientCA, bool user, bool warn) {

security/manager/ssl/nsNSSCertValidity.h

@@ -17,7 +17,7 @@ class nsX509CertValidity : public nsIX509CertValidity {
   explicit nsX509CertValidity(const mozilla::UniqueCERTCertificate& cert);
 
  protected:
-  virtual ~nsX509CertValidity() {}
+  virtual ~nsX509CertValidity() = default;
 
  private:
   nsresult FormatTime(const PRTime& aTime, PRTimeParamFn aParamFn,

security/manager/ssl/nsNSSCertificateDB.h

@@ -33,7 +33,7 @@ class nsNSSCertificateDB final : public nsIX509CertDB
       nsTArray<RefPtr<nsIX509Cert>>& aCertListOut);
 
  protected:
-  virtual ~nsNSSCertificateDB() {}
+  virtual ~nsNSSCertificateDB() = default;
 
  private:
   // Use this function to generate a default nickname for a user

security/manager/ssl/nsNSSComponent.cpp

@@ -1245,11 +1245,11 @@ class CipherSuiteChangeObserver : public nsIObserver {
   static nsresult StartObserve();
 
  protected:
-  virtual ~CipherSuiteChangeObserver() {}
+  virtual ~CipherSuiteChangeObserver() = default;
 
  private:
   static StaticRefPtr<CipherSuiteChangeObserver> sObserver;
-  CipherSuiteChangeObserver() {}
+  CipherSuiteChangeObserver() = default;
 };
 
 NS_IMPL_ISUPPORTS(CipherSuiteChangeObserver, nsIObserver)
@@ -2307,7 +2307,7 @@ nsNSSComponent::IssuerMatchesMitmCanary(const char* aCertIssuer) {
   return NS_ERROR_FAILURE;
 }
 
-SharedCertVerifier::~SharedCertVerifier() {}
+SharedCertVerifier::~SharedCertVerifier() = default;
 
 NS_IMETHODIMP
 nsNSSComponent::GetDefaultCertVerifier(SharedCertVerifier** result) {
@@ -2441,9 +2441,9 @@ UniqueCERTCertList FindClientCertificatesWithPrivateKeys() {
 
 NS_IMPL_ISUPPORTS(PipUIContext, nsIInterfaceRequestor)
 
-PipUIContext::PipUIContext() {}
+PipUIContext::PipUIContext() = default;
 
-PipUIContext::~PipUIContext() {}
+PipUIContext::~PipUIContext() = default;
 
 NS_IMETHODIMP
 PipUIContext::GetInterface(const nsIID& uuid, void** result) {

security/manager/ssl/nsNSSIOLayer.cpp

@@ -138,7 +138,7 @@ nsNSSSocketInfo::nsNSSSocketInfo(SharedSSLState& aState, uint32_t providerFlags,
   mTLSVersionRange.max = 0;
 }
 
-nsNSSSocketInfo::~nsNSSSocketInfo() {}
+nsNSSSocketInfo::~nsNSSSocketInfo() = default;
 
 NS_IMPL_ISUPPORTS_INHERITED(nsNSSSocketInfo, TransportSecurityInfo,
                             nsISSLSocketControl)
@@ -1360,7 +1360,7 @@ class PrefObserver : public nsIObserver {
   explicit PrefObserver(nsSSLIOLayerHelpers* aOwner) : mOwner(aOwner) {}
 
  protected:
-  virtual ~PrefObserver() {}
+  virtual ~PrefObserver() = default;
 
  private:
   nsSSLIOLayerHelpers* mOwner;

security/manager/ssl/nsNSSVersion.cpp

@@ -13,9 +13,9 @@
 
 NS_IMPL_ISUPPORTS(nsNSSVersion, nsINSSVersion)
 
-nsNSSVersion::nsNSSVersion() {}
+nsNSSVersion::nsNSSVersion() = default;
 
-nsNSSVersion::~nsNSSVersion() {}
+nsNSSVersion::~nsNSSVersion() = default;
 
 NS_IMETHODIMP
 nsNSSVersion::GetNSPR_Version(nsAString& v) {

security/manager/ssl/nsPK11TokenDB.h

@@ -24,7 +24,7 @@ class nsPK11Token : public nsIPK11Token {
   explicit nsPK11Token(PK11SlotInfo* slot);
 
  protected:
-  virtual ~nsPK11Token() {}
+  virtual ~nsPK11Token() = default;
 
  private:
   friend class nsPK11TokenDB;
@@ -51,10 +51,10 @@ class nsPK11TokenDB : public nsIPK11TokenDB {
   NS_DECL_ISUPPORTS
   NS_DECL_NSIPK11TOKENDB
 
-  nsPK11TokenDB() {}
+  nsPK11TokenDB() = default;
 
  protected:
-  virtual ~nsPK11TokenDB() {}
+  virtual ~nsPK11TokenDB() = default;
 };
 
 #define NS_PK11TOKENDB_CID                           \

security/manager/ssl/nsPKCS11Slot.h

@@ -22,7 +22,7 @@ class nsPKCS11Slot : public nsIPKCS11Slot {
   explicit nsPKCS11Slot(PK11SlotInfo* slot);
 
  protected:
-  virtual ~nsPKCS11Slot() {}
+  virtual ~nsPKCS11Slot() = default;
 
  private:
   mozilla::UniquePK11SlotInfo mSlot;
@@ -49,7 +49,7 @@ class nsPKCS11Module : public nsIPKCS11Module {
   explicit nsPKCS11Module(SECMODModule* module);
 
  protected:
-  virtual ~nsPKCS11Module() {}
+  virtual ~nsPKCS11Module() = default;
 
  private:
   mozilla::UniqueSECMODModule mModule;

security/manager/ssl/nsPKCS12Blob.h

@@ -25,7 +25,7 @@ class nsIX509Cert;
 class nsPKCS12Blob {
  public:
   nsPKCS12Blob();
-  ~nsPKCS12Blob() {}
+  ~nsPKCS12Blob() = default;
 
   // PKCS#12 Import
   nsresult ImportFromFile(nsIFile* file, const nsAString& password,

security/manager/ssl/nsProtectedAuthThread.cpp

@@ -36,7 +36,7 @@ nsProtectedAuthThread::nsProtectedAuthThread()
       mSlot(0),
       mLoginResult(SECFailure) {}
 
-nsProtectedAuthThread::~nsProtectedAuthThread() {}
+nsProtectedAuthThread::~nsProtectedAuthThread() = default;
 
 NS_IMETHODIMP nsProtectedAuthThread::Login(nsIObserver* aObserver) {
   NS_ENSURE_ARG(aObserver);

security/manager/ssl/nsRandomGenerator.h

@@ -23,7 +23,7 @@ class nsRandomGenerator final : public nsIRandomGenerator {
   NS_DECL_NSIRANDOMGENERATOR
 
  private:
-  ~nsRandomGenerator() {}
+  ~nsRandomGenerator() = default;
 };
 
 #endif  // nsRandomGenerator_h

security/manager/ssl/nsSSLSocketProvider.cpp

@@ -11,9 +11,9 @@
 
 using mozilla::OriginAttributes;
 
-nsSSLSocketProvider::nsSSLSocketProvider() {}
+nsSSLSocketProvider::nsSSLSocketProvider() = default;
 
-nsSSLSocketProvider::~nsSSLSocketProvider() {}
+nsSSLSocketProvider::~nsSSLSocketProvider() = default;
 
 NS_IMPL_ISUPPORTS(nsSSLSocketProvider, nsISocketProvider)
 

security/manager/ssl/nsSecureBrowserUIImpl.h

@@ -39,7 +39,7 @@ class nsSecureBrowserUIImpl : public nsISecureBrowserUI,
   NS_DECL_NSISECUREBROWSERUI
 
  protected:
-  virtual ~nsSecureBrowserUIImpl(){};
+  virtual ~nsSecureBrowserUIImpl() = default;
 
   already_AddRefed<mozilla::dom::Document> PrepareForContentChecks();
   // Do mixed content checks. May update mState.

security/manager/ssl/nsSiteSecurityService.cpp

@@ -460,7 +460,7 @@ nsSiteSecurityService::nsSiteSecurityService()
       mProcessPKPHeadersFromNonBuiltInRoots(false),
       mDafsa(kDafsa) {}
 
-nsSiteSecurityService::~nsSiteSecurityService() {}
+nsSiteSecurityService::~nsSiteSecurityService() = default;
 
 NS_IMPL_ISUPPORTS(nsSiteSecurityService, nsIObserver, nsISiteSecurityService)
 

security/manager/ssl/nsSiteSecurityService.h

@@ -96,7 +96,7 @@ class SiteHPKPState : public nsISiteHPKPState {
   void ToString(nsCString& aString);
 
  protected:
-  virtual ~SiteHPKPState(){};
+  virtual ~SiteHPKPState() = default;
 };
 
 /**
@@ -148,7 +148,7 @@ class SiteHSTSState : public nsISiteHSTSState {
   void ToString(nsCString& aString);
 
  protected:
-  virtual ~SiteHSTSState() {}
+  virtual ~SiteHSTSState() = default;
 };
 
 struct nsSTSPreload;

security/manager/ssl/nsTLSSocketProvider.cpp

@@ -11,9 +11,9 @@
 
 using mozilla::OriginAttributes;
 
-nsTLSSocketProvider::nsTLSSocketProvider() {}
+nsTLSSocketProvider::nsTLSSocketProvider() = default;
 
-nsTLSSocketProvider::~nsTLSSocketProvider() {}
+nsTLSSocketProvider::~nsTLSSocketProvider() = default;
 
 NS_IMPL_ISUPPORTS(nsTLSSocketProvider, nsISocketProvider)
 

security/sandbox/common/SandboxSettings.cpp

@@ -73,10 +73,10 @@ class SandboxSettings final : public mozISandboxSettings {
   NS_DECL_ISUPPORTS
   NS_DECL_MOZISANDBOXSETTINGS
 
-  SandboxSettings() {}
+  SandboxSettings() = default;
 
  private:
-  ~SandboxSettings() {}
+  ~SandboxSettings() = default;
 };
 
 NS_IMPL_ISUPPORTS(SandboxSettings, mozISandboxSettings)

security/sandbox/linux/SandboxInfo.h

@@ -17,7 +17,7 @@ namespace mozilla {
 class SandboxInfo {
  public:
   // No need to prevent copying; this is essentially just a const int.
-  SandboxInfo(const SandboxInfo& aOther) : mFlags(aOther.mFlags) {}
+  SandboxInfo(const SandboxInfo& aOther) = default;
 
   // Flags are checked at initializer time; this returns them.
   static const SandboxInfo& Get() { return sSingleton; }

security/sandbox/linux/launch/LinuxCapabilities.h

@@ -40,7 +40,7 @@ class LinuxCapabilities final {
     __u32 mMask;
     friend class LinuxCapabilities;
     BitRef(__u32& aWord, uint32_t aMask) : mWord(aWord), mMask(aMask) {}
-    BitRef(const BitRef& aBit) : mWord(aBit.mWord), mMask(aBit.mMask) {}
+    BitRef(const BitRef& aBit) = default;
 
    public:
     MOZ_IMPLICIT operator bool() const { return mWord & mMask; }