зеркало из https://github.com/mozilla/gecko-dev.git
Bug 1501622 - For consistency, clear innerHTML in SwatchTooltips;r=pbro
Depends on D9648 Note that this is not strictly necessary since the set* methods are only called when the Swatch tooltips are built, so they always operate on "new" HTML Tooltips. But since this is not very self explanatory I think it will be less surprising to be on the safe side and clear innerHTML in the methods directly. Differential Revision: https://phabricator.services.mozilla.com/D9649 --HG-- extra : moz-landing-system : lando
This commit is contained in:
Родитель
566f6da124
Коммит
92f43aeec4
|
@ -51,6 +51,7 @@ class SwatchColorPickerTooltip extends SwatchBasedEditorTooltip {
|
|||
|
||||
setColorPickerContent(color) {
|
||||
const { doc } = this.tooltip;
|
||||
this.tooltip.panel.innerHTML = "";
|
||||
|
||||
const container = doc.createElementNS(XHTML_NS, "div");
|
||||
container.id = "spectrum-tooltip";
|
||||
|
|
|
@ -41,6 +41,7 @@ class SwatchCubicBezierTooltip extends SwatchBasedEditorTooltip {
|
|||
|
||||
setCubicBezierContent(bezier) {
|
||||
const { doc } = this.tooltip;
|
||||
this.tooltip.panel.innerHTML = "";
|
||||
|
||||
const container = doc.createElementNS(XHTML_NS, "div");
|
||||
container.className = "cubic-bezier-container";
|
||||
|
|
|
@ -43,6 +43,7 @@ class SwatchFilterTooltip extends SwatchBasedEditorTooltip {
|
|||
|
||||
setFilterContent(filter) {
|
||||
const { doc } = this.tooltip;
|
||||
this.tooltip.panel.innerHTML = "";
|
||||
|
||||
const container = doc.createElementNS(XHTML_NS, "div");
|
||||
container.id = "filter-container";
|
||||
|
|
Загрузка…
Ссылка в новой задаче