Bug 538450 - Part 4: Remove JSRuntime::offThreadParsesRunning_. r=jonco

Differential Revision: https://phabricator.services.mozilla.com/D131366

js/src/threading/ProtectedData.cpp

@@ -120,12 +120,7 @@ void CheckArenaListAccess<Helper>::check() const {
     return;
   }
 
-  JSRuntime* rt = TlsContext.get()->runtime();
   if (zone->isAtomsZone()) {
-    // We must hold the GC lock if parallel parsing is running.
-    if (rt->isOffThreadParseRunning()) {
-      rt->gc.assertCurrentThreadHasLockedGC();
-    }
     return;
   }
 

js/src/vm/Runtime.cpp

@@ -156,7 +156,6 @@ JSRuntime::JSRuntime(JSRuntime* parentRuntime)
       offthreadIonCompilationEnabled_(true),
       parallelParsingEnabled_(true),
 #ifdef DEBUG
-      offThreadParsesRunning_(0),
       offThreadParsingBlocked_(false),
 #endif
       autoWritableJitCodeActive_(false),
@@ -188,7 +187,6 @@ JSRuntime::~JSRuntime() {
 
   MOZ_ASSERT(wasmInstances.lock()->empty());
 
-  MOZ_ASSERT(offThreadParsesRunning_ == 0);
   MOZ_ASSERT(!offThreadParsingBlocked_);
 
   MOZ_ASSERT(numRealms == 0);

js/src/vm/Runtime.h

@@ -947,7 +947,6 @@ struct JSRuntime {
       parallelParsingEnabled_;
 
 #ifdef DEBUG
-  mozilla::Atomic<uint32_t> offThreadParsesRunning_;
   mozilla::Atomic<bool> offThreadParsingBlocked_;
 #endif
 
@@ -969,22 +968,9 @@ struct JSRuntime {
 
 #ifdef DEBUG
 
-  void incOffThreadParsesRunning() {
-    MOZ_ASSERT(!isOffThreadParsingBlocked());
-    offThreadParsesRunning_++;
-  }
-
-  void decOffThreadParsesRunning() {
-    MOZ_ASSERT(isOffThreadParseRunning());
-    offThreadParsesRunning_--;
-  }
-
-  bool isOffThreadParseRunning() const { return offThreadParsesRunning_; }
-
   bool isOffThreadParsingBlocked() const { return offThreadParsingBlocked_; }
   void setOffThreadParsingBlocked(bool blocked) {
     MOZ_ASSERT(offThreadParsingBlocked_ != blocked);
-    MOZ_ASSERT(!isOffThreadParseRunning());
     offThreadParsingBlocked_ = blocked;
   }