Bug 1162635 - flatten notification styles on Windows and Linux, r=dao

--HG--
extra : commitid : 8dPIxhXV8wl
extra : rebase_source : 53203f85e91fc99f9716f054bb4410803e59f33b
extra : histedit_source : f037b5dbb6cb94bf9ca8e2aa3a9177aa15463f97

browser/base/content/browser.css

@@ -602,10 +602,7 @@ menupopup[emptyplacesresult="true"] > .hide-if-empty-places-result {
 menuitem.spell-suggestion {
   font-weight: bold;
 }
-/* apply Fitts' law to the notification bar's close button */
-window:not([sizemode="normal"]) .notification-inner {
-  -moz-border-end-width: 0 !important;
-}
+
 /* Hide extension toolbars that neglected to set the proper class */
 window[chromehidden~="location"][chromehidden~="toolbar"] toolbar:not(.chromeclass-menubar),
 window[chromehidden~="toolbar"] toolbar:not(#nav-bar):not(#TabsToolbar):not(#print-preview-toolbar):not(.chromeclass-menubar) {

browser/base/content/browser.xul

@@ -1092,7 +1092,7 @@
 
       <splitter id="sidebar-splitter" class="chromeclass-extrachrome sidebar-splitter" hidden="true"/>
       <vbox id="appcontent" flex="1">
-        <notificationbox id="high-priority-global-notificationbox"/>
+        <notificationbox id="high-priority-global-notificationbox" notificationside="top"/>
         <tabbrowser id="content"
                     flex="1" contenttooltip="aHTMLTooltip"
                     tabcontainer="tabbrowser-tabs"
@@ -1175,7 +1175,7 @@
   </html:div>
 
   <vbox id="browser-bottombox" layer="true">
-    <notificationbox id="global-notificationbox"/>
+    <notificationbox id="global-notificationbox" notificationside="bottom"/>
     <toolbar id="developer-toolbar"
              hidden="true">
 #ifdef XP_MACOSX

browser/base/content/tabbrowser.xml

@@ -20,7 +20,7 @@
                   flex="1" eventnode="document" xbl:inherits="handleCtrlPageUpDown"
                   onselect="if (event.target.localName == 'tabpanels') this.parentNode.updateCurrentBrowser();">
         <xul:tabpanels flex="1" class="plain" selectedIndex="0" anonid="panelcontainer">
-          <xul:notificationbox flex="1">
+          <xul:notificationbox flex="1" notificationside="top">
             <xul:hbox flex="1" class="browserSidebarContainer">
               <xul:vbox flex="1" class="browserContainer">
                 <xul:stack flex="1" class="browserStack" anonid="browserStack">
@@ -1743,6 +1743,7 @@
             var notificationbox = document.createElementNS(NS_XUL,
                                                            "notificationbox");
             notificationbox.setAttribute("flex", "1");
+            notificationbox.setAttribute("notificationside", "top");
             notificationbox.appendChild(browserSidebarContainer);
 
             // Prevent the superfluous initial load of a blank document

toolkit/content/widgets/notification.xml

@@ -383,7 +383,7 @@
 
   <binding id="notification" role="xul:alert">
     <content>
-      <xul:hbox class="notification-inner outset" flex="1" xbl:inherits="type">
+      <xul:hbox class="notification-inner" flex="1" xbl:inherits="type">
         <xul:hbox anonid="details" align="center" flex="1"
                   oncommand="this.parentNode.parentNode._doButtonCommand(event);">
           <xul:image anonid="messageImage" class="messageImage" xbl:inherits="src=image,type,value"/>

toolkit/themes/linux/global/notification.css

@@ -6,7 +6,6 @@
 
 notification {
   color: -moz-gtk-info-bar-text;
-  background-color: InfoBackground;
   -moz-appearance: -moz-gtk-info-bar;
   text-shadow: none;
 }

toolkit/themes/osx/global/notification.css

@@ -56,10 +56,6 @@ notification[type="critical"] {
   list-style-image: url("chrome://global/skin/notification/error-icon.png");
 }
 
-.notification-inner {
-  border: 0 !important;
-}
-
 .messageText {
   margin: 0 3px !important;
   padding: 0;

toolkit/themes/windows/global/notification.css

@@ -8,6 +8,16 @@ notification {
   color: InfoText;
   background-color: InfoBackground;
   text-shadow: none;
+  border-top: 1px solid ThreeDShadow;
+  border-bottom: 1px solid ThreeDShadow;
+}
+
+notificationbox[notificationside="top"] > notification {
+  border-top-style: none;
+}
+
+notificationbox[notificationside="bottom"] > notification {
+  border-bottom-style: none;
 }
 
 notification[type="info"] {