Bug 1641459 - Do not allow the setting of sameSite=lax/strict cookies from cross-site iframe documents - part 2 - tests, r=annevk

Differential Revision: https://phabricator.services.mozilla.com/D77245
This commit is contained in:
Andrea Marchesini 2020-05-29 15:54:34 +00:00
Родитель 58c2fe71b1
Коммит 948adbdc87
4 изменённых файлов: 70 добавлений и 1 удалений

Просмотреть файл

@ -0,0 +1,4 @@
[iframe.document.html]
[Same-site iframes can set lax/strict cookies via document.cookie]
expected:
if fission: FAIL # Bug 1641905

Просмотреть файл

@ -68,7 +68,7 @@ function create_cookie(origin, name, value, extras) {
function set_prefixed_cookie_via_dom_test(options) {
promise_test(t => {
var name = options.prefix + "prefixtestcookie";
erase_cookie_from_js(name, options.paras);
erase_cookie_from_js(name, options.params);
t.add_cleanup(() => erase_cookie_from_js(name, options.params));
var value = "" + Math.random();
document.cookie = name + "=" + value + ";" + options.params;

Просмотреть файл

@ -0,0 +1,57 @@
<!DOCTYPE html>
<meta charset="utf-8"/>
<meta name="timeout" content="long">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/cookies/resources/cookie-helper.sub.js"></script>
<!-- We're appending an <iframe> to the document's body, so execute tests after we have a body -->
<body>
<script>
function create_test(target, expectedDomStatus, title) {
promise_test(async t => {
let cookieValue = await new Promise((resolve, reject) => {
var iframe = document.createElement("iframe");
window.onmessage = t.step_func(e => {
if (e.source == iframe.contentWindow) {
document.body.removeChild(iframe);
resolve(e.data.value);
}
});
iframe.src = target + "/cookies/samesite/resources/iframe.document.html";
document.body.appendChild(iframe);
});
await new Promise((resolve, reject) => {
var iframe = document.createElement("iframe");
window.onmessage = t.step_func(e => {
if (e.source == iframe.contentWindow) {
// Cleanup, then verify cookie state:
document.body.removeChild(iframe);
const cookies = e.data;
assert_equals(cookies["dc_samesite_none"], cookieValue, "SameSite=none cookies can be set via document.cookies even by cross-origin documents");
if (expectedDomStatus === DomSameSiteStatus.SAME_SITE) {
assert_equals(cookies["dc_samesite_lax"], cookieValue, "SameSite=lax cookies can be set via document.cookies by same-site documents");
assert_equals(cookies["dc_samesite_strict"], cookieValue, "SameSite=strict cookies can be set via document.cookies by same-site documents");
} else if (expectedDomStatus === DomSameSiteStatus.CROSS_SITE) {
assert_not_equals(cookies["dc_samesite_lax"], cookieValue, "SameSite=lax cookies can be set via document.cookies by same-site documents");
assert_not_equals(cookies["dc_samesite_strict"], cookieValue, "SameSite=strict cookies can be set via document.cookies by same-site documents");
}
resolve();
}
});
iframe.src = target + "/cookies/resources/postToParent.py";
document.body.appendChild(iframe);
});
}, title);
}
create_test(SECURE_ORIGIN, DomSameSiteStatus.SAME_SITE, "Same-site iframes can set lax/strict cookies via document.cookie");
create_test(SECURE_CROSS_SITE_ORIGIN, DomSameSiteStatus.CROSS_SITE, "Cross-site iframe cannot set lax/strict cookies via document.cookie");
</script>

Просмотреть файл

@ -0,0 +1,8 @@
<!DOCTYPE html>
<script>
var value = "" + Math.random();
document.cookie = `dc_samesite_strict=${value}; secure; sameSite=strict; path=/`;
document.cookie = `dc_samesite_lax=${value}; secure; sameSite=lax; path=/`;
document.cookie = `dc_samesite_none=${value}; secure; sameSite=none; path=/`;
parent.postMessage({value}, "*");
</script>