mozilla
/
gecko-dev
зеркало из https://github.com/mozilla/gecko-dev.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность

Bug 1654161 [wpt PR 24676] - [FlexNG] Use block % resolution size when finding image preferred widths, a=testonly 

Automatic update from web-platform-tests
[FlexNG] Use block % resolution size when finding image preferred widths

Flex uses image preferred widths as flex-basis. When an image has
max-height:blah%, that can affect its preferred width. FlexNG wasn't
passing the percent resolution height to legacy for this calculation,
and the % max-height was being treated as auto.

ComputeMinAndMaxContentContribution was already doing this for replaced
elements, so piggy-back on that code.

Bug: 1107604
Change-Id: Icecb312ce8aee22cad6e4b1925aab77ecbd3c2ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309048
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#790439}

--

wpt-commits: 29d3cd461ae5de247d09d945dfc275b1c82e2370
wpt-pr: 24676
This commit is contained in:
David Grogan 2020-07-22 20:03:27 +00:00 коммит произвёл moz-wptsync-bot
Родитель 38736f57a6
Коммит 959e7b2259
1 изменённых файлов: 57 добавлений и 0 удалений
Показать статистику Скачать Patch файл Скачать Diff файл Показать все файлы Свернуть все файлы

57
testing/web-platform/tests/css/css-flexbox/percentage-max-height-003.html Normal file
Просмотреть файл

@ -0,0 +1,57 @@
<!doctype html>
<link rel="author" title="David Grogan" href="mailto:dgrogan@chromium.org">
<link rel="help" href="https://drafts.csswg.org/css-flexbox/#definite-sizes">
<link rel="match" href="../reference/ref-filled-green-100px-square.xht">
<link rel="bookmark" href="https://crbug.com/1107604">
<meta name="assert" content="Replaced children with % max-height are sized correctly when they are deeply nested flex items with imposed definite heights." />
<style>
#reference-overlapped-red {
position: absolute;
background-color: red;
width: 100px;
height: 100px;
z-index: -1;
}
#outer-flexbox {
display: flex;
width: 200px;
height: 200px;
flex-direction: column;
align-items: flex-start;
}
#middle-flexbox {
display: flex;
height: 50%;
/* This needs to be stretched for repro */
align-items: stretch;
min-height: 0px;
}
#inner-flexbox {
display: flex;
align-items: flex-start;
min-width: 0px;
}
img {
max-height: 100%;
min-width: 0px;
}
</style>
<p>Test passes if there is a filled green square and <strong>no red</strong>.</p>
<div id="reference-overlapped-red"></div>
<div id=outer-flexbox>
<div id=middle-flexbox>
<div id=inner-flexbox>
<!-- This is a 400x400 green square. It's inline so that there is no
raciness when an image resource loads, which affects chrome's behavior
on this test. -->
<img src="data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 400 400' width='400' height='400'><rect width='400' height='400' fill='green'/></svg>">
</div>
</div>
</div>