Bug 875138 - Update devtools tab to be compatible with XBL refactoring changes. r=jwalker

--HG--
extra : rebase_source : b2eeb09bcdc089b064dc657fdecd2ee548ed5032

browser/devtools/framework/test/browser_new_activation_workflow.js

@@ -43,7 +43,7 @@ function selectAndCheckById(id) {
 
   return toolbox.selectTool(id).then(function() {
     let tab = doc.getElementById("toolbox-tab-" + id);
-    is(tab.selected, true, "The " + id + " tab is selected");
+    is(tab.hasAttribute("selected"), true, "The " + id + " tab is selected");
   });
 }
 

browser/devtools/framework/toolbox.css

@@ -2,10 +2,9 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
-.devtools-tab > .radio-check,
-.devtools-tab > .radio-check-box1,
-.devtools-tab > .radio-spacer-box {
-  display: none;
+.devtools-tab {
+  -moz-binding: url("chrome://global/content/bindings/general.xml#control-item");
+  -moz-box-align: center;
 }
 
 #toolbox-controls > toolbarbutton > .toolbarbutton-text,

browser/devtools/framework/toolbox.js

@@ -351,6 +351,9 @@ Toolbox.prototype = {
     let id = toolDefinition.id;
 
     let radio = this.doc.createElement("radio");
+    // The radio element is not being used in the conventional way, thus
+    // the devtools-tab class replaces the radio XBL binding with its base
+    // binding (the control-item binding).
     radio.className = "toolbox-tab devtools-tab";
     radio.id = "toolbox-tab-" + id;
     radio.setAttribute("toolid", id);