Bug 1528690 - P2 - Change some assertions to diagnostic assertion to get more information on Nightly; r=asuth

Depends on D28148

Differential Revision: https://phabricator.services.mozilla.com/D28149

--HG--
extra : moz-landing-system : lando

dom/indexedDB/ActorsParent.cpp

@@ -11533,7 +11533,7 @@ void ConnectionPool::PerformIdleDatabaseMaintenance(
 void ConnectionPool::CloseDatabase(DatabaseInfo* aDatabaseInfo) {
   AssertIsOnOwningThread();
   MOZ_ASSERT(aDatabaseInfo);
-  MOZ_ASSERT(!aDatabaseInfo->TotalTransactionCount());
+  MOZ_DIAGNOSTIC_ASSERT(!aDatabaseInfo->TotalTransactionCount());
   MOZ_ASSERT(aDatabaseInfo->mThreadInfo.mThread);
   MOZ_ASSERT(aDatabaseInfo->mThreadInfo.mRunnable);
   MOZ_ASSERT(!aDatabaseInfo->mClosing);