From 981a623dfeca9e5b1f860ec29d23f477315e2432 Mon Sep 17 00:00:00 2001 From: Tom Ritter Date: Wed, 27 Apr 2022 12:57:36 +0000 Subject: [PATCH] Bug 1752332: Remove the blocklisting check in ::OnPreferenceChange r=KrisWright Now that we send everything (except sometimes the user value is sanitized) we should no longer perform this check. This is also good because it eliminates security code you have to have (and thus accidently omitting it is a vulnerability) and changes it to security code that happens automatically, and is enforced by the compiler (via mandatory ctor argument.) Depends on D141414 Differential Revision: https://phabricator.services.mozilla.com/D141415 --- dom/ipc/ContentParent.cpp | 6 ------ dom/media/ipc/RDDProcessManager.cpp | 4 ---- gfx/ipc/GPUProcessManager.cpp | 4 ---- gfx/vr/ipc/VRProcessManager.cpp | 4 ---- ipc/glue/UtilityProcessManager.cpp | 5 ----- 5 files changed, 23 deletions(-) diff --git a/dom/ipc/ContentParent.cpp b/dom/ipc/ContentParent.cpp index 89c674dbca52..dc5c34b4940e 100644 --- a/dom/ipc/ContentParent.cpp +++ b/dom/ipc/ContentParent.cpp @@ -3639,12 +3639,6 @@ ContentParent::Observe(nsISupports* aSubject, const char* aTopic, // We know prefs are ASCII here. NS_LossyConvertUTF16toASCII strData(aData); - // A pref changed. If it is useful to do so, inform child processes. - if (ShouldSanitizePreference(strData.Data(), - /* will be fixed later */ false)) { - return NS_OK; - } - Pref pref(strData, /* isLocked */ false, /* isSanitized */ false, Nothing(), Nothing()); diff --git a/dom/media/ipc/RDDProcessManager.cpp b/dom/media/ipc/RDDProcessManager.cpp index 07cef63921a9..2e2e5eec18b8 100644 --- a/dom/media/ipc/RDDProcessManager.cpp +++ b/dom/media/ipc/RDDProcessManager.cpp @@ -96,10 +96,6 @@ void RDDProcessManager::OnPreferenceChange(const char16_t* aData) { // We know prefs are ASCII here. NS_LossyConvertUTF16toASCII strData(aData); - // A pref changed. If it is useful to do so, inform child processes. - if (ShouldSanitizePreference(strData.Data(), false)) { - return; - } mozilla::dom::Pref pref(strData, /* isLocked */ false, /* isSanitized */ false, Nothing(), Nothing()); diff --git a/gfx/ipc/GPUProcessManager.cpp b/gfx/ipc/GPUProcessManager.cpp index 7a8a93c656eb..8ce0395e3938 100644 --- a/gfx/ipc/GPUProcessManager.cpp +++ b/gfx/ipc/GPUProcessManager.cpp @@ -163,10 +163,6 @@ void GPUProcessManager::OnPreferenceChange(const char16_t* aData) { // We know prefs are ASCII here. NS_LossyConvertUTF16toASCII strData(aData); - // A pref changed. If it is useful to do so, inform child processes. - if (ShouldSanitizePreference(strData.Data(), false)) { - return; - } mozilla::dom::Pref pref(strData, /* isLocked */ false, /* isSanitized */ false, Nothing(), Nothing()); diff --git a/gfx/vr/ipc/VRProcessManager.cpp b/gfx/vr/ipc/VRProcessManager.cpp index 86f5c6799279..f3bc13bac03b 100644 --- a/gfx/vr/ipc/VRProcessManager.cpp +++ b/gfx/vr/ipc/VRProcessManager.cpp @@ -216,10 +216,6 @@ void VRProcessManager::OnPreferenceChange(const char16_t* aData) { // We know prefs are ASCII here. NS_LossyConvertUTF16toASCII strData(aData); - // A pref changed. If it is useful to do so, inform child processes. - if (ShouldSanitizePreference(strData.Data(), false)) { - return; - } mozilla::dom::Pref pref(strData, /* isLocked */ false, /* isSanitized */ false, Nothing(), Nothing()); diff --git a/ipc/glue/UtilityProcessManager.cpp b/ipc/glue/UtilityProcessManager.cpp index f403d77dc889..040702b97aa6 100644 --- a/ipc/glue/UtilityProcessManager.cpp +++ b/ipc/glue/UtilityProcessManager.cpp @@ -94,11 +94,6 @@ void UtilityProcessManager::OnPreferenceChange(const char16_t* aData) { // We know prefs are ASCII here. NS_LossyConvertUTF16toASCII strData(aData); - // A pref changed. If it is useful to do so, inform child processes. - if (ShouldSanitizePreference(strData.Data(), false)) { - return; - } - mozilla::dom::Pref pref(strData, /* isLocked */ false, /* isSanitized */ false, Nothing(), Nothing()); Preferences::GetPreference(&pref, GeckoProcessType_Utility,