Bug 1551639 - Use .inc suffix for generated source files that are only included. r=nalexander

There is a big difference between generated source files that are built
directly, and those that are only included.

In the latter case, the build system won't know the files that does the
including depends on the generated source. So those sources do need to
be built during the export tier.

But in the former case, the build system has all the dependency
information it needs, and, while these generated sources are currently
built as part of the export tier, they don't actually need to be. We're
going to change that, and in preparation, we rename included files so as
to be more clearly identified.

Differential Revision: https://phabricator.services.mozilla.com/D33770

--HG--
extra : moz-landing-system : lando

config/check_spidermonkey_style.py

@@ -62,7 +62,7 @@ included_inclnames_to_ignore = set([
     'javascript-trace.h',       # generated in $OBJDIR if HAVE_DTRACE is defined
     'frontend/ReservedWordsGenerated.h',  # generated in $OBJDIR
     'gc/StatsPhasesGenerated.h',         # generated in $OBJDIR
-    'gc/StatsPhasesGenerated.cpp',       # generated in $OBJDIR
+    'gc/StatsPhasesGenerated.inc',       # generated in $OBJDIR
     'jit/LOpcodes.h',           # generated in $OBJDIR
     'jit/MOpcodes.h',           # generated in $OBJDIR
     'jscustomallocator.h',      # provided by embedders;  allowed to be missing
@@ -118,7 +118,7 @@ oddly_ordered_inclnames = set([
     # Included in the body of frontend/TokenStream.h
     'frontend/ReservedWordsGenerated.h',
     'gc/StatsPhasesGenerated.h',         # Included in the body of gc/Statistics.h
-    'gc/StatsPhasesGenerated.cpp',       # Included in the body of gc/Statistics.cpp
+    'gc/StatsPhasesGenerated.inc',       # Included in the body of gc/Statistics.cpp
     'psapi.h',                  # Must be included after "util/Windows.h" on Windows
     'machine/endian.h',         # Must be included after <sys/types.h> on BSD
     'winbase.h',                # Must precede other system headers(?)

js/src/gc/Statistics.cpp

@@ -147,7 +147,7 @@ using PhaseTable = EnumeratedArray<Phase, Phase::LIMIT, PhaseInfo>;
 using PhaseKindTable =
     EnumeratedArray<PhaseKind, PhaseKind::LIMIT, PhaseKindInfo>;
 
-#include "gc/StatsPhasesGenerated.cpp"
+#include "gc/StatsPhasesGenerated.inc"
 
 static double t(TimeDuration duration) { return duration.ToMilliseconds(); }
 

js/src/gc/moz.build

@@ -17,10 +17,10 @@ include('../js-cxxflags.mozbuild')
 
 
 # Generate GC statistics phase data.
-GENERATED_FILES += ['StatsPhasesGenerated.cpp', 'StatsPhasesGenerated.h']
+GENERATED_FILES += ['StatsPhasesGenerated.h', 'StatsPhasesGenerated.inc']
 StatsPhasesGeneratedHeader = GENERATED_FILES['StatsPhasesGenerated.h']
 StatsPhasesGeneratedHeader.script = 'GenerateStatsPhases.py:generateHeader'
-StatsPhasesGeneratedCpp = GENERATED_FILES['StatsPhasesGenerated.cpp']
+StatsPhasesGeneratedCpp = GENERATED_FILES['StatsPhasesGenerated.inc']
 StatsPhasesGeneratedCpp.script = 'GenerateStatsPhases.py:generateCpp'
 
 UNIFIED_SOURCES += [

layout/style/moz.build

@@ -287,7 +287,7 @@ servo_props.inputs = [
 if CONFIG['COMPILE_ENVIRONMENT']:
     GENERATED_FILES += [
         'CompositorAnimatableProperties.h',
-        'nsComputedDOMStyleGenerated.cpp',
+        'nsComputedDOMStyleGenerated.inc',
         'nsCSSPropsGenerated.inc',
         'ServoStyleConsts.h',
     ]
@@ -303,7 +303,7 @@ if CONFIG['COMPILE_ENVIRONMENT']:
         '!ServoCSSPropList.py',
     ]
 
-    computed = GENERATED_FILES['nsComputedDOMStyleGenerated.cpp']
+    computed = GENERATED_FILES['nsComputedDOMStyleGenerated.inc']
     computed.script = 'GenerateComputedDOMStyleGenerated.py:generate'
     computed.inputs = [
         '!ServoCSSPropList.py',

layout/style/nsComputedDOMStyle.cpp

@@ -199,7 +199,7 @@ struct ComputedStyleMap {
 
   // This generated file includes definition of kEntries which is typed
   // Entry[] and used below, so this #include has to be put here.
-#include "nsComputedDOMStyleGenerated.cpp"
+#include "nsComputedDOMStyleGenerated.inc"
 
   /**
    * Returns the number of properties that should be exposed on an