Bug 1447904 - for clang-tidy toolchains set default cxx dialect cxx14. r=froydnj

MozReview-Commit-ID: LrGETsz0W6q

--HG--
extra : rebase_source : e419fd1d138ef17c00644c2bd91f7b6b9924a413

build/build-clang/clang-tidy-cxx14.patch

@@ -0,0 +1,23 @@
+Backport cxx14 default dialect flag from clang 6.0.0 trunk to 5.0.1
+
+Index: lib/Frontend/CompilerInvocation.cpp
+===================================================================
+--- a/clang/tools/lib/Frontend/CompilerInvocation.cpp	(revision 320871)
++++ b/clang/tools/lib/Frontend/CompilerInvocation.cpp	(working copy)
+@@ -1690,11 +1690,11 @@
+       break;
+     case InputKind::CXX:
+     case InputKind::ObjCXX:
+-      // The PS4 uses C++11 as the default C++ standard.
+-      if (T.isPS4())
+-        LangStd = LangStandard::lang_gnucxx11;
+-      else
+-        LangStd = LangStandard::lang_gnucxx98;
++#if defined(CLANG_DEFAULT_STD_CXX)
++      LangStd = CLANG_DEFAULT_STD_CXX;
++#else
++      LangStd = LangStandard::lang_gnucxx14;
++#endif
+       break;
+     case InputKind::RenderScript:
+       LangStd = LangStandard::lang_c99;

build/build-clang/clang-tidy-linux64.json

@@ -15,5 +15,8 @@
     "gcc_dir": "/builds/worker/workspace/build/src/gcc",
     "cc": "/builds/worker/workspace/build/src/gcc/bin/gcc",
     "cxx": "/builds/worker/workspace/build/src/gcc/bin/g++",
-    "as": "/builds/worker/workspace/build/src/gcc/bin/gcc"
+    "as": "/builds/worker/workspace/build/src/gcc/bin/gcc",
+    "patches": [
+      "clang-tidy-cxx14.patch"
+    ]
 }

build/build-clang/clang-tidy-macosx64.json

@@ -23,6 +23,7 @@
     "patches": [
       "llvm-debug-frame-for-5.patch",
       "compiler-rt-cross-compile.patch",
-      "compiler-rt-no-codesign.patch"
+      "compiler-rt-no-codesign.patch",
+      "clang-tidy-cxx14.patch"
     ]
 }

build/build-clang/clang-tidy-win32.json

@@ -12,5 +12,8 @@
     "libcxx_repo": "https://llvm.org/svn/llvm-project/libcxx/trunk",
     "python_path": "c:/mozilla-build/python/python.exe",
     "cc": "cl.exe",
-    "cxx": "cl.exe"
+    "cxx": "cl.exe",
+    "patches": [
+      "clang-tidy-cxx14.patch"
+    ]
 }

build/build-clang/clang-tidy-win64.json

@@ -13,5 +13,8 @@
     "python_path": "c:/mozilla-build/python/python.exe",
     "cc": "cl.exe",
     "cxx": "cl.exe",
-    "ml": "ml64.exe"
+    "ml": "ml64.exe",
+    "patches": [
+      "clang-tidy-cxx14.patch"
+    ]
 }