From 998c60bb1661420c4457a12661e073b8e0b380c9 Mon Sep 17 00:00:00 2001 From: Anders Hartvoll Ruud Date: Sun, 8 May 2022 17:50:54 +0000 Subject: [PATCH] Bug 1768169 [wpt PR 33963] - Disable incremental styling for animated ComputedStyles, a=testonly Automatic update from web-platform-tests Disable incremental styling for animated ComputedStyles For ComputedStyles that are affected by animation effects, we also store the corresponding *base style* on that animated ComputedStyle. This currently interacts poorly with incremental styling, since we copy the (potentially animated) ComputedStyle from the Element, which may already have the base style stored. StyleResolver::ApplyAnimatedStyle may then store *that* style as a base style again, potentially creating an infinite chain of base styles. This problem can't be reproduced with DCHECKs enabled, since we call ApplyBaseStyleNoCache to verify that the incremental ComputedStyle is equal to the ComputedStyle we would produce with a full resolution. However, the diff is blind to to fields which aren't generated, which includes the BaseData. Bug: 1313554 Change-Id: I24ce40b7ec9a54f818098b21e1125f0071c11b24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3629398 Reviewed-by: Steinar H Gunderson Commit-Queue: Anders Hartvoll Ruud Cr-Commit-Position: refs/heads/main@{#1000332} -- wpt-commits: f33ef39a7f8e26ff9361b68c55b33284a549c907 wpt-pr: 33963 --- .../transition-during-style-attr-mutation.html | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 testing/web-platform/tests/css/css-transitions/crashtests/transition-during-style-attr-mutation.html diff --git a/testing/web-platform/tests/css/css-transitions/crashtests/transition-during-style-attr-mutation.html b/testing/web-platform/tests/css/css-transitions/crashtests/transition-during-style-attr-mutation.html new file mode 100644 index 000000000000..255794bfa86d --- /dev/null +++ b/testing/web-platform/tests/css/css-transitions/crashtests/transition-during-style-attr-mutation.html @@ -0,0 +1,12 @@ + +Don't crash when mutating style attribute with non-initial transition + + +
PASS if no crash
+