make blocked popup view color less objectionable, add close button, fix leaking of view.

camino/resources/localized/English.lproj/PopupBlockView.nib/classes.nib

@@ -3,6 +3,7 @@
         {
             ACTIONS = {
                 configurePopupBlocking = id; 
+                hideBlockedPopupView = id; 
                 reloadWithNewCharset = id; 
                 unblockPopupSites = id; 
             }; 

camino/resources/localized/English.lproj/PopupBlockView.nib/info.nib

@@ -7,7 +7,7 @@
 	<key>IBEditorPositions</key>
 	<dict>
 		<key>5</key>
-		<string>284 781 609 73 0 0 1920 1178 </string>
+		<string>655 769 645 72 0 0 1920 1178 </string>
 	</dict>
 	<key>IBFramework Version</key>
 	<string>443.0</string>

camino/src/browser/BrowserWrapper.h

@@ -133,7 +133,7 @@ class nsISupportsArray;
   NSString*                 mLoadingStatusString;
   ToolTip*                  mToolTip;
 
-  IBOutlet NSView*          mBlockedPopupView;   // loaded on demand, can be nil
+  IBOutlet NSView*          mBlockedPopupView;   // loaded on demand, can be nil, STRONG
 
   double                    mProgress;
   
@@ -181,6 +181,7 @@ class nsISupportsArray;
 - (void)getBlockedSites:(nsISupportsArray**)outSites;
 - (IBAction)configurePopupBlocking:(id)sender;
 - (IBAction)unblockPopupSites:(id)sender;
+- (IBAction)hideBlockedPopupView:(id)sender;
 
 - (void)loadURI:(NSString *)urlSpec referrer:(NSString*)referrer flags:(unsigned int)flags activate:(BOOL)activate allowPopups:(BOOL)inAllowPopups;
 

camino/src/browser/BrowserWrapper.mm

@@ -177,6 +177,10 @@ static NSString* const kOfflineNotificationName = @"offlineModeChanged";
   [mBrowserView release];
   [mContentViewProviders release];
 
+  // |mBlockedPopupView| has a retain count of 1 when it comes out of the nib,
+  // we have to release it manually.
+  [mBlockedPopupView release];
+  
   [super dealloc];
 }
 
@@ -1056,6 +1060,11 @@ static NSString* const kOfflineNotificationName = @"offlineModeChanged";
   }
 }
 
+- (IBAction)hideBlockedPopupView:(id)sender
+{
+  [self removeBlockedPopupViewAndDisplay];
+}
+
 @end
 
 #pragma mark -
@@ -1070,7 +1079,7 @@ static NSString* const kOfflineNotificationName = @"offlineModeChanged";
 - (void)drawRect:(NSRect)aRect
 {
   // draw background color
-  [[NSColor orangeColor] set];
+  [[NSColor colorWithCalibratedRed:1.0 green:0.9 blue:0.58 alpha:1.0] set];
   NSRectFill([self frame]);
   
   // draw shadowed border