Bug 1568903 - Part 1: Clean-up GlobalObject.h includes. r=jorendorff

GlobalObject.h had an unnecessary #include for ErrorObject.h, which led to
recompiling more or less all of SpiderMonkey when modifying ErrorObject.h,
because GlobalObject.h is (transitively) included in most files.

Differential Revision: https://phabricator.services.mozilla.com/D51649

--HG--
extra : moz-landing-system : lando

js/src/builtin/Object.cpp

@@ -21,6 +21,7 @@
 #include "vm/AsyncFunction.h"
 #include "vm/DateObject.h"
 #include "vm/EqualityOperations.h"  // js::SameValue
+#include "vm/ErrorObject.h"
 #include "vm/JSContext.h"
 #include "vm/RegExpObject.h"
 

js/src/builtin/TestingFunctions.cpp

@@ -69,6 +69,7 @@
 #include "util/Text.h"
 #include "vm/AsyncFunction.h"
 #include "vm/AsyncIteration.h"
+#include "vm/ErrorObject.h"
 #include "vm/GlobalObject.h"
 #include "vm/Interpreter.h"
 #include "vm/Iteration.h"

js/src/jit/RangeAnalysis.cpp

@@ -11,6 +11,8 @@
 
 #include <algorithm>
 
+#include "jsnum.h"
+
 #include "jit/Ion.h"
 #include "jit/IonAnalysis.h"
 #include "jit/JitSpewer.h"

js/src/jsfriendapi.cpp

@@ -28,6 +28,7 @@
 #include "util/Poison.h"
 #include "vm/ArgumentsObject.h"
 #include "vm/DateObject.h"
+#include "vm/ErrorObject.h"
 #include "vm/FrameIter.h"  // js::FrameIter
 #include "vm/JSContext.h"
 #include "vm/JSObject.h"

js/src/vm/GlobalObject.cpp

@@ -50,6 +50,7 @@
 #include "vm/AsyncIteration.h"
 #include "vm/DateObject.h"
 #include "vm/EnvironmentObject.h"
+#include "vm/ErrorObject.h"
 #include "vm/GeneratorObject.h"
 #include "vm/HelperThreads.h"
 #include "vm/JSContext.h"

js/src/vm/GlobalObject.h

@@ -7,23 +7,52 @@
 #ifndef vm_GlobalObject_h
 #define vm_GlobalObject_h
 
-#include "jsexn.h"
-#include "jsnum.h"
+#include "mozilla/Assertions.h"
+#include "mozilla/DebugOnly.h"
 
-#include "builtin/Array.h"
-#include "builtin/Boolean.h"
-#include "js/Vector.h"
-#include "vm/ArrayBufferObject.h"
-#include "vm/ErrorObject.h"
+#include <stdint.h>
+#include <type_traits>
+
+#include "jsapi.h"
+#include "jsexn.h"
+#include "jsfriendapi.h"
+#include "jspubtd.h"
+#include "jstypes.h"
+#include "NamespaceImports.h"
+
+#include "gc/AllocKind.h"
+#include "gc/Rooting.h"
+#include "js/CallArgs.h"
+#include "js/Class.h"
+#include "js/ErrorReport.h"
+#include "js/PropertyDescriptor.h"
+#include "js/RootingAPI.h"
+#include "js/TypeDecls.h"
+#include "js/Value.h"
+#include "vm/JSContext.h"
 #include "vm/JSFunction.h"
+#include "vm/JSObject.h"
+#include "vm/NativeObject.h"
 #include "vm/Realm.h"
 #include "vm/Runtime.h"
+#include "vm/Shape.h"
+#include "vm/StringType.h"
+
+struct JSFunctionSpec;
+struct JSPrincipals;
+struct JSPropertySpec;
+
+namespace JS {
+class JS_PUBLIC_API RealmOptions;
+};
 
 namespace js {
 
-class TypedObjectModuleObject;
+class GlobalScope;
 class LexicalEnvironmentObject;
 class RegExpStatics;
+class TypeDescr;
+class TypedObjectModuleObject;
 
 enum class ReferenceType;
 
@@ -925,9 +954,6 @@ extern bool DefinePropertiesAndFunctions(JSContext* cx, HandleObject obj,
                                          const JSPropertySpec* ps,
                                          const JSFunctionSpec* fs);
 
-typedef HashSet<GlobalObject*, DefaultHasher<GlobalObject*>, SystemAllocPolicy>
-    GlobalObjectSet;
-
 extern bool DefineToStringTag(JSContext* cx, HandleObject obj, JSAtom* tag);
 
 /*

js/src/vm/JSContext.cpp

@@ -50,6 +50,7 @@
 #include "util/NativeStack.h"
 #include "util/Windows.h"
 #include "vm/BytecodeUtil.h"
+#include "vm/ErrorObject.h"
 #include "vm/ErrorReporting.h"
 #include "vm/HelperThreads.h"
 #include "vm/Iteration.h"

js/src/vm/ObjectGroup.cpp

@@ -19,6 +19,7 @@
 #include "js/CharacterEncoding.h"
 #include "js/UniquePtr.h"
 #include "vm/ArrayObject.h"
+#include "vm/ErrorObject.h"
 #include "vm/GlobalObject.h"
 #include "vm/JSObject.h"
 #include "vm/RegExpObject.h"

js/src/wasm/WasmCode.cpp

@@ -23,6 +23,8 @@
 
 #include <algorithm>
 
+#include "jsnum.h"
+
 #include "jit/ExecutableAllocator.h"
 #ifdef JS_ION_PERF
 #  include "jit/PerfSpewer.h"

js/src/wasm/WasmJS.cpp

@@ -35,6 +35,7 @@
 #include "js/PropertySpec.h"  // JS_{PS,FN}{,_END}
 #include "util/StringBuffer.h"
 #include "util/Text.h"
+#include "vm/ErrorObject.h"
 #include "vm/Interpreter.h"
 #include "vm/StringType.h"
 #include "wasm/WasmBaselineCompile.h"