Bug 1595915 - Don't check #fill-login-popup visibility in pwgen context menu tests. r=sfoster

For now I didn't change tests to not open the submenu when only generating a password as it should be harmless.

Differential Revision: https://phabricator.services.mozilla.com/D60641

--HG--
extra : moz-landing-system : lando

toolkit/components/passwordmgr/test/browser/browser_context_menu_generated_password.js

@@ -49,7 +49,6 @@ add_task(async function test_hidden_by_prefs() {
 
       await openPasswordContextMenu(browser, passwordInputSelector);
 
-      let loginPopup = document.getElementById("fill-login-popup");
       let generatedPasswordItem = document.getElementById(
         "fill-login-generated-password"
       );
@@ -57,8 +56,6 @@ add_task(async function test_hidden_by_prefs() {
         "generated-password-separator"
       );
 
-      // Check the content of the password manager popup
-      ok(BrowserTestUtils.is_visible(loginPopup), "popup is visible");
       ok(
         !BrowserTestUtils.is_visible(generatedPasswordItem),
         "generated password item is hidden"
@@ -89,7 +86,6 @@ add_task(async function test_fill_hidden_by_login_saving_disabled() {
 
       await openPasswordContextMenu(browser, passwordInputSelector);
 
-      let loginPopup = document.getElementById("fill-login-popup");
       let generatedPasswordItem = document.getElementById(
         "fill-login-generated-password"
       );
@@ -97,8 +93,6 @@ add_task(async function test_fill_hidden_by_login_saving_disabled() {
         "generated-password-separator"
       );
 
-      // Check the content of the password manager popup
-      ok(BrowserTestUtils.is_visible(loginPopup), "popup is visible");
       ok(
         !BrowserTestUtils.is_visible(generatedPasswordItem),
         "generated password item is hidden"

toolkit/components/passwordmgr/test/browser/head.js

@@ -685,7 +685,6 @@ async function doFillGeneratedPasswordContextMenuItem(browser, passwordInput) {
   await SimpleTest.promiseFocus(browser);
   await openPasswordContextMenu(browser, passwordInput);
 
-  let loginPopup = document.getElementById("fill-login-popup");
   let generatedPasswordItem = document.getElementById(
     "fill-login-generated-password"
   );
@@ -693,8 +692,6 @@ async function doFillGeneratedPasswordContextMenuItem(browser, passwordInput) {
     "generated-password-separator"
   );
 
-  // Check the content of the password manager popup
-  ok(BrowserTestUtils.is_visible(loginPopup), "Popup is visible");
   ok(
     BrowserTestUtils.is_visible(generatedPasswordItem),
     "generated password item is visible"