Bug 609532 - Stop checking in code with warnings. r=dwitte.

js/src/Makefile.in

@@ -88,6 +88,7 @@ MODULE_OPTIMIZE_FLAGS = -O2 -ip
 endif
 else # not INTEL_CXX
 
+FAIL_ON_WARNINGS = 1
 MODULE_OPTIMIZE_FLAGS = -O3 -fstrict-aliasing
 
 # We normally want -fomit-frame-pointer, but we want an explicit

js/src/editline/editline.c

@@ -190,7 +190,7 @@ TTYput(c)
 
 STATIC void
 TTYputs(p)
-    CHAR	*p;
+    CONST CHAR	*p;
 {
     while (*p)
 	TTYput(*p++);

js/src/jsxdrapi.cpp

@@ -431,7 +431,7 @@ JS_XDRString(JSXDRState *xdr, JSString **strp)
                                              (*strp)->length(),
                                              true);
         /* js_GetDeflatedUTF8StringLength never fails in CESU8 mode */
-        JS_ASSERT(len != -1);
+        JS_ASSERT(len != (size_t) -1);
         JS_ASSERT(size_t(uint32(len)) == len);
         /* ensure MAX_LENGTH strings can always fit when CESU8 encoded */
         JS_STATIC_ASSERT(JSString::MAX_LENGTH < (uint32(-1) / 3));

js/src/shell/Makefile.in

@@ -56,6 +56,8 @@ LIBS      = $(NSPR_LIBS) $(EDITLINE_LIBS) $(DEPTH)/$(LIB_PREFIX)js_static.$(LIB_
 
 LOCAL_INCLUDES += -I$(topsrcdir) -I..
 
+FAIL_ON_WARNINGS = 1
+
 ifdef _MSC_VER
 ifdef WINCE
 WIN32_EXE_LDFLAGS += -ENTRY:mainACRTStartup

js/src/shell/js.cpp

@@ -201,7 +201,9 @@ js::workers::ThreadPool *gWorkerThreadPool = NULL;
 static JSBool reportWarnings = JS_TRUE;
 static JSBool compileOnly = JS_FALSE;
 
+#ifdef DEBUG
 static JSBool OOM_printAllocationCount = JS_FALSE;
+#endif
 
 typedef enum JSShellErrNum {
 #define MSG_DEF(name, number, count, exception, format) \