From 9aa980c04a27c6922aec2dbdd5b6a6323b60f192 Mon Sep 17 00:00:00 2001
From: "scc%mozilla.org" <scc%mozilla.org>
Date: Sun, 3 Sep 2000 05:47:01 +0000
Subject: [PATCH] explicit constructors stop the automatic construction of a
 string for a comparison.  Really, they want the equivalent of |IsEmpty()|
 here; let's just test the value of the char[0] in the buffer.

---
 netwerk/base/src/nsProtocolProxyService.cpp | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/netwerk/base/src/nsProtocolProxyService.cpp b/netwerk/base/src/nsProtocolProxyService.cpp
index 02df6effda5b..73e31ccebc79 100644
--- a/netwerk/base/src/nsProtocolProxyService.cpp
+++ b/netwerk/base/src/nsProtocolProxyService.cpp
@@ -280,7 +280,7 @@ nsProtocolProxyService::ExamineForProxy(nsIURI *aURI, nsIProxy *aProxy) {
     rv = aURI->GetScheme(getter_Copies(scheme));
     if (NS_FAILED(rv)) return rv;
     
-    if (mFTPProxyHost != "" && mFTPProxyPort > 0 &&
+    if (mFTPProxyHost.get()[0] && mFTPProxyPort > 0 &&
         !PL_strcasecmp(scheme, "ftp")) {
         rv = aProxy->SetProxyHost(mFTPProxyHost);
         if (NS_FAILED(rv)) return rv;
@@ -288,7 +288,7 @@ nsProtocolProxyService::ExamineForProxy(nsIURI *aURI, nsIProxy *aProxy) {
         return aProxy->SetProxyPort(mFTPProxyPort);
     }
     
-    if (mHTTPProxyHost != "" && mHTTPProxyPort > 0 &&
+    if (mHTTPProxyHost.get()[0] && mHTTPProxyPort > 0 &&
         !PL_strcasecmp(scheme, "http")) {
         rv = aProxy->SetProxyHost(mHTTPProxyHost);
         if (NS_FAILED(rv)) return rv;
@@ -296,7 +296,7 @@ nsProtocolProxyService::ExamineForProxy(nsIURI *aURI, nsIProxy *aProxy) {
         return aProxy->SetProxyPort(mHTTPProxyPort);
     }
     
-    if (mHTTPSProxyHost != "" && mHTTPSProxyPort > 0 &&
+    if (mHTTPSProxyHost.get()[0] && mHTTPSProxyPort > 0 &&
         !PL_strcasecmp(scheme, "https")) {
         rv = aProxy->SetProxyHost(mHTTPSProxyHost);
         if (NS_FAILED(rv)) return rv;
@@ -304,7 +304,7 @@ nsProtocolProxyService::ExamineForProxy(nsIURI *aURI, nsIProxy *aProxy) {
         return aProxy->SetProxyPort(mHTTPSProxyPort);
     }
     
-    if (mSOCKSProxyHost != "" && mSOCKSProxyPort > 0) {
+    if (mSOCKSProxyHost.get()[0] && mSOCKSProxyPort > 0) {
         rv = aProxy->SetProxyHost(mSOCKSProxyHost);
         if (NS_FAILED(rv)) return rv;
         aProxy->SetProxyType("socks");