Bug 1662254 - Rename CC_WAITING -> CC_FINISHED r=jonco

Differential Revision: https://phabricator.services.mozilla.com/D94792

devtools/client/locales/en-US/markers.properties

@@ -118,7 +118,7 @@ marker.gcreason.label.PERIODIC_FULL_GC=Periodic Full GC
 marker.gcreason.label.INCREMENTAL_TOO_SLOW=Allocations Rate Too Fast
 marker.gcreason.label.COMPONENT_UTILS=Cu.forceGC
 marker.gcreason.label.MEM_PRESSURE=Low Memory
-marker.gcreason.label.CC_WAITING=Forced by Cycle Collection
+marker.gcreason.label.CC_FINISHED=Cycle Collection Finished
 marker.gcreason.label.CC_FORCED=Forced by Cycle Collection
 marker.gcreason.label.LOAD_END=Page Load Finished
 marker.gcreason.label.PAGE_HIDE=Moved to Background

dom/base/nsJSEnvironment.cpp

@@ -1523,7 +1523,7 @@ void nsJSContext::EndCycleCollectionCallback(CycleCollectorResults& aResults) {
                    kMaxICCDuration.ToMilliseconds(),
                "A max duration ICC shouldn't reduce GC delay to 0");
 
-    PokeGC(JS::GCReason::CC_WAITING, nullptr,
+    PokeGC(JS::GCReason::CC_FINISHED, nullptr,
            StaticPrefs::javascript_options_gc_delay() -
                std::min(ccNowDuration, kMaxICCDuration).ToMilliseconds());
   }
@@ -1803,7 +1803,7 @@ void nsJSContext::PokeGC(JS::GCReason aReason, JSObject* aObj,
   if (aObj) {
     JS::Zone* zone = JS::GetObjectZone(aObj);
     CycleCollectedJSRuntime::Get()->AddZoneWaitingForGC(zone);
-  } else if (aReason != JS::GCReason::CC_WAITING) {
+  } else if (aReason != JS::GCReason::CC_FINISHED) {
     sScheduler.SetNeedsFullGC();
   }
 

js/public/GCAPI.h

@@ -508,7 +508,7 @@ namespace JS {
   D(DOM_WINDOW_UTILS, FIRST_FIREFOX_REASON) \
   D(COMPONENT_UTILS, 34)                    \
   D(MEM_PRESSURE, 35)                       \
-  D(CC_WAITING, 36)                         \
+  D(CC_FINISHED, 36)                        \
   D(CC_FORCED, 37)                          \
   D(LOAD_END, 38)                           \
   D(UNUSED3, 39)                            \

js/src/doc/Debugger/Debugger.Memory.md

@@ -176,7 +176,7 @@ triggered. Known values include the following:
 * `"DOM_WINDOW_UTILS"`
 * `"COMPONENT_UTILS"`
 * `"MEM_PRESSURE"`
-* `"CC_WAITING"`
+* `"CC_FINISHED"`
 * `"CC_FORCED"`
 * `"LOAD_END"`
 * `"PAGE_HIDE"`

js/src/gc/Scheduling.h

@@ -108,9 +108,9 @@
  *  Correctness reasons:
  *
  *   3) Do a GC now because correctness depends on some GC property. For
- *      example, CC_WAITING is where the embedding requires the mark bits
- *      to be set correct. Also, EVICT_NURSERY where we need to work on the
- *      tenured heap.
+ *      example, CC_FORCED is where the embedding requires the mark bits to be
+ *      set correctly. Also, EVICT_NURSERY where we need to work on the tenured
+ *      heap.
  *
  *   4) Do a GC because we are shutting down: e.g. SHUTDOWN_CC or DESTROY_*.
  *