Bug 563936 - Make google_breakpad::ClientInfo::UnregisterWaits handle pseudo-errors from UnregisterWait correctly if there is I/O pending at the time, r=doshimun a=mossop

toolkit/crashreporter/google-breakpad/src/client/windows/crash_generation/client_info.cc

@@ -101,26 +101,16 @@ ClientInfo::~ClientInfo() {
   }
 }
 
-bool ClientInfo::UnregisterWaits() {
-  bool success = true;
-
+void ClientInfo::UnregisterWaits() {
   if (dump_request_wait_handle_) {
-    if (!UnregisterWait(dump_request_wait_handle_)) {
-      success = false;
-    } else {
-      dump_request_wait_handle_ = NULL;
-    }
+    UnregisterWait(dump_request_wait_handle_);
+    dump_request_wait_handle_ = NULL;
   }
 
   if (process_exit_wait_handle_) {
-    if (!UnregisterWait(process_exit_wait_handle_)) {
-      success = false;
-    } else {
-      process_exit_wait_handle_ = NULL;
-    }
+    UnregisterWait(process_exit_wait_handle_);
+    process_exit_wait_handle_ = NULL;
   }
-
-  return success;
 }
 
 bool ClientInfo::GetClientExceptionInfo(EXCEPTION_POINTERS** ex_info) const {

toolkit/crashreporter/google-breakpad/src/client/windows/crash_generation/client_info.h

@@ -83,7 +83,7 @@ class ClientInfo {
   }
 
   // Unregister all waits for the client.
-  bool UnregisterWaits();
+  void UnregisterWaits();
 
   bool Initialize();
   bool GetClientExceptionInfo(EXCEPTION_POINTERS** ex_info) const;