Bug 1680506 - String change to Recent activity should be pref controlled. r=ewright,fluent-reviewers,thecount,flod

Differential Revision: https://phabricator.services.mozilla.com/D98914

browser/components/newtab/lib/SectionsManager.jsm

@@ -94,7 +94,13 @@ const BUILT_IN_SECTIONS = {
   "feeds.section.highlights": options => ({
     id: "highlights",
     pref: {
-      titleString: { id: "home-prefs-recent-activity-header" },
+      titleString: {
+        id: Services.prefs.getBoolPref(
+          "browser.newtabpage.activity-stream.newNewtabExperience.enabled"
+        )
+          ? "home-prefs-recent-activity-header"
+          : "home-prefs-highlights-header",
+      },
       descString: { id: "home-prefs-highlights-description" },
       nestedPrefs: [
         {
@@ -122,7 +128,13 @@ const BUILT_IN_SECTIONS = {
     shouldHidePref: false,
     eventSource: "HIGHLIGHTS",
     icon: "highlights",
-    title: { id: "newtab-section-header-recent-activity" },
+    title: {
+      id: Services.prefs.getBoolPref(
+        "browser.newtabpage.activity-stream.newNewtabExperience.enabled"
+      )
+        ? "newtab-section-header-recent-activity"
+        : "newtab-section-header-highlights",
+    },
     compactCards: true,
     rowsPref: "section.highlights.rows",
     maxRows: 4,

browser/locales/en-US/browser/newtab/newtab.ftl

@@ -179,6 +179,7 @@ newtab-section-expand-section-label =
 ## Section Headers.
 
 newtab-section-header-topsites = Top Sites
+newtab-section-header-highlights = Highlights
 newtab-section-header-recent-activity = Recent activity
 # Variables:
 #  $provider (String): Name of the corresponding content provider.

browser/locales/en-US/browser/preferences/preferences.ftl

@@ -634,6 +634,8 @@ home-prefs-recommended-by-learn-more = How it works
 home-prefs-recommended-by-option-sponsored-stories =
     .label = Sponsored Stories
 
+home-prefs-highlights-header =
+    .label = Highlights
 home-prefs-recent-activity-header =
     .label = Recent activity
 home-prefs-highlights-description = A selection of sites that you’ve saved or visited