Backed out 2 changesets (bug 1591925) for failures on select-element-zero-height-001.html. CLOSED TREE

Backed out changeset b2d168294899 (bug 1591925)
Backed out changeset bbeb8f308193 (bug 1591925)
This commit is contained in:
Csoregi Natalia 2019-11-14 05:11:41 +02:00
Родитель acb0f164ca
Коммит 9c5c3803e2
6 изменённых файлов: 6 добавлений и 83 удалений

Просмотреть файл

@ -2093,19 +2093,18 @@ void FlexItem::CheckForMinSizeAuto(const ReflowInput& aFlexItemReflowInput,
// the flex container's main axis) iff:
// (a) its computed value is "auto"
// (b) the "overflow" sub-property in the same axis (the main axis) has a
// computed value of "visible" and the item does not create a scroll
// container.
// computed value of "visible"
const auto& mainMinSize = aAxisTracker.IsRowOriented()
? pos->MinISize(aAxisTracker.GetWritingMode())
: pos->MinBSize(aAxisTracker.GetWritingMode());
// If the scrollable overflow makes us create a scroll container, then we
// don't need to do any extra resolution for our `min-size:auto` value.
// We don't need to check for scrollable overflow in a particular axis
// because this will be true for both or neither axis.
// NOTE: Technically we should be checking the 'overflow' subproperty in the
// main axis. But since we only care whether it's 'visible', we can check
// either subproperty -- because they must be BOTH 'visible' or BOTH
// non-'visible' due to the way the subproperties interact.
mNeedsMinSizeAutoResolution =
IsAutoOrEnumOnBSize(mainMinSize, IsInlineAxisMainAxis()) &&
!disp->IsScrollableOverflow();
disp->mOverflowX == StyleOverflow::Visible;
}
nscoord FlexItem::GetBaselineOffsetFromOuterCrossEdge(

Просмотреть файл

@ -1,3 +0,0 @@
[select-element-zero-height-001.html]
expected: FAIL
bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1596255

Просмотреть файл

@ -1,14 +0,0 @@
<!DOCTYPE html>
<title>Reference: Select element in flexbox with zero height</title>
<link rel="author" title="Mozilla" href="https://mozilla.org">
<style>
.container {
height: 0px;
border: 1px dotted black;
}
</style>
<body>
<div class="container">
<select style="width:100%"><option>Hi</option></select>
</div>
</body>

Просмотреть файл

@ -1,19 +0,0 @@
<!DOCTYPE html>
<title>Select element in flexbox with zero height</title>
<link rel="author" title="Mozilla" href="https://mozilla.org">
<link rel="help" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1591925">
<link rel="help" href="https://drafts.csswg.org/css-flexbox/#content-size-suggestion">
<link rel="match" href="select-element-zero-height-001-ref.html">
<style>
.container {
display: flex;
flex-direction: column;
height: 0px;
border: 1px dotted black;
}
</style>
<body>
<div class="container">
<select><option>Hi</option></select>
</div>
</body>

Просмотреть файл

@ -1,18 +0,0 @@
<!DOCTYPE html>
<title>Reference: Select element with background color in flexbox with zero height</title>
<link rel="author" title="Mozilla" href="https://mozilla.org">
<style>
.container {
height: 0px;
border: 1px dotted black;
}
.with-background {
width: 100%;
background: lime;
}
</style>
<body>
<div class="container">
<select class="with-background"><option>Hi</option></select>
</div>
</body>

Просмотреть файл

@ -1,22 +0,0 @@
<!DOCTYPE html>
<title>Select element with background color in flexbox with zero height</title>
<link rel="author" title="Mozilla" href="https://mozilla.org">
<link rel="help" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1591925">
<link rel="help" href="https://drafts.csswg.org/css-flexbox/#content-size-suggestion">
<link rel="match" href="select-element-zero-height-002-ref.html">
<style>
.container {
display: flex;
flex-direction: column;
height: 0px;
border: 1px dotted black;
}
.with-background {
background: lime;
}
</style>
<body>
<div class="container">
<select class="with-background"><option>Hi</option></select>
</div>
</body>