From 9c78e3edbda211d3e2bafa54e8735a30709176a1 Mon Sep 17 00:00:00 2001 From: Gijs Kruitbosch Date: Wed, 9 Apr 2014 13:54:44 +0100 Subject: [PATCH] Bug 989683 - restrict how we inherit the menubar text color to tabsintitlebar cases on non-aero, r=dao --- browser/themes/windows/browser-aero.css | 12 ++++++++++++ browser/themes/windows/browser.css | 20 ++++++++++++++++---- 2 files changed, 28 insertions(+), 4 deletions(-) diff --git a/browser/themes/windows/browser-aero.css b/browser/themes/windows/browser-aero.css index 99969c748ef6..e98c689d4fbc 100644 --- a/browser/themes/windows/browser-aero.css +++ b/browser/themes/windows/browser-aero.css @@ -144,6 +144,18 @@ border-right-style: none !important; } + /* Use a different color only on Windows 8 and higher for inactive windows. + * On aero, the menubar fog disappears for inactive windows, and renders gray + * illegible. + */ + @media not all and (-moz-os-version: windows-vista) { + @media not all and (-moz-os-version: windows-win7) { + #toolbar-menubar:not(:-moz-lwtheme):-moz-window-inactive { + color: ThreeDShadow; + } + } + } + #main-window[darkwindowframe="true"] #toolbar-menubar:not(:-moz-lwtheme):not(:-moz-window-inactive), #main-window[darkwindowframe="true"] #TabsToolbar:not(:-moz-lwtheme):not(:-moz-window-inactive) { color: white; diff --git a/browser/themes/windows/browser.css b/browser/themes/windows/browser.css index 9d2c76723736..6d557f23899d 100644 --- a/browser/themes/windows/browser.css +++ b/browser/themes/windows/browser.css @@ -109,12 +109,24 @@ %endif /* Make the menu inherit the toolbar's color. On non-compositor (Aero Basic, XP modern, classic) - * this is defined above. Otherwise (Aero Glass, Windows 8 inactive windows), this is hardcoded - * to black in browser-aero.css. */ -#main-menubar > menu:not(:-moz-lwtheme) { - color: inherit; + * this is defined above, but only for tabsintitlebar. Otherwise (Aero Glass, Windows 8), + * this is hardcoded to black in browser-aero.css, even without tabsintitlebar. */ +%ifdef WINDOWS_AERO +@media not all and (-moz-windows-compositor) { +%endif + #main-window[tabsintitlebar] #main-menubar > menu:not(:-moz-lwtheme) { + color: inherit; + } +%ifdef WINDOWS_AERO } +@media (-moz-windows-compositor) { + #main-menubar > menu:not(:-moz-lwtheme) { + color: inherit; + } +} +%endif + /** * In the classic themes, the titlebar has a horizontal gradient, which is * problematic for reading the text of background tabs when they're in the