48465">http://bugzilla.mozilla.org/show_bug.cgi?id=48465

added fix for bug 48465
a=ben
r=rjc
added function so in mail bookmarks sidebar
opens in top window

xpfe/components/bookmarks/resources/bm-panel.js

@@ -46,7 +46,7 @@ function clicked(event, target)
 	if (target.getAttribute("container") == "true")
 		return(false);
 
-	OpenBookmarkURL(event, target, document.getElementById('bookmarksTree').database);
+	sidebarOpenURL(event, target, document.getElementById('bookmarksTree').database);
 	return(true);
 }
 
@@ -162,5 +162,19 @@ function sidebarOpenURL(event, treeitem, root)
 	catch(ex)
 	{
 	}
-  openTopWin(id);
+    // Ignore "NC:" urls.
+	if (id.substring(0, 3) == "NC:")
+	{
+		return(false);
+	}	
+	if (event.metaKey) 
+	  {
+	  // if metaKey is down, open in a new browser window
+  		window.openDialog( getBrowserURL(), "_blank", "chrome,all,dialog=no", id ); 
+	  } 
+	  else 
+	  {
+		openTopWin(id);
+	  }
 }
+

xpfe/components/bookmarks/resources/bm-panel.xul

@@ -53,7 +53,7 @@
       ondraggesture="return BeginDragTree(event);"
       ondragdrop="return DropOnTree(event);"
       datasources="rdf:bookmarks rdf:files rdf:localsearch rdf:internetsearch rdf:httpindex" 
-      onclick="sidebarOpenURL(event, event.target.parentNode.parentNode, 'Tree')">
+      onclick=" return clicked(event, event.target.parentNode.parentNode, 'Tree')">
 
       <template>
         <rule rdf:type="http://home.netscape.com/NC-rdf#BookmarkSeparator">