Bug 1774287 - Part 2: Add helpers.getIsTopLevelScript. r=Standard8

Depends on D149606

Differential Revision: https://phabricator.services.mozilla.com/D149607

tools/lint/eslint/eslint-plugin-mozilla/lib/helpers.js

@@ -489,26 +489,7 @@ module.exports = {
   },
 
   /**
-   * Check whether a node is a function.
-   *
-   * @param {Object} node
-   *        The AST node to check
-   *
-   * @return {Boolean}
-   *         True or false
-   */
-  getIsFunctionNode(node) {
-    switch (node.type) {
-      case "ArrowFunctionExpression":
-      case "FunctionDeclaration":
-      case "FunctionExpression":
-        return true;
-    }
-    return false;
-  },
-
-  /**
-   * Check whether the context is the global scope.
+   * Check whether it's inside top-level script.
    *
    * @param {Array} ancestors
    *        The parents of the current node.
@@ -516,10 +497,15 @@ module.exports = {
    * @return {Boolean}
    *         True or false
    */
-  getIsGlobalScope(ancestors) {
+  getIsTopLevelScript(ancestors) {
     for (let parent of ancestors) {
-      if (this.getIsFunctionNode(parent)) {
-        return false;
+      switch (parent.type) {
+        case "ArrowFunctionExpression":
+        case "FunctionDeclaration":
+        case "FunctionExpression":
+        case "PropertyDefinition":
+        case "StaticBlock":
+          return false;
       }
     }
     return true;

tools/lint/eslint/eslint-plugin-mozilla/lib/rules/reject-top-level-await.js

@@ -26,13 +26,16 @@ module.exports = {
   create(context) {
     return {
       AwaitExpression(node) {
-        if (!helpers.getIsGlobalScope(context.getAncestors())) {
+        if (!helpers.getIsTopLevelScript(context.getAncestors())) {
           return;
         }
         context.report({ node, messageId: "rejectTopLevelAwait" });
       },
       ForOfStatement(node) {
-        if (!node.await || !helpers.getIsGlobalScope(context.getAncestors())) {
+        if (
+          !node.await ||
+          !helpers.getIsTopLevelScript(context.getAncestors())
+        ) {
           return;
         }
         context.report({ node, messageId: "rejectTopLevelAwait" });

tools/lint/eslint/eslint-plugin-mozilla/lib/rules/var-only-at-top-level.js

@@ -24,7 +24,7 @@ module.exports = {
     return {
       VariableDeclaration(node) {
         if (node.kind === "var") {
-          if (helpers.getIsGlobalScope(context.getAncestors())) {
+          if (helpers.getIsTopLevelScript(context.getAncestors())) {
             return;
           }