Explicit conversion required for NEW_STRING_APIS. r=scc

string/obsolete/nsString.cpp

@@ -662,7 +662,8 @@ char* nsCString::ToNewCString() const {
  * @return  ptr to new ascii string
  */
 PRUnichar* nsCString::ToNewUnicode() const {
-  nsString temp(*this);         //construct nsCString with alloc on heap (which we'll steal in a moment)
+  nsString temp;
+  temp.AssignWithConversion(*this);         //construct nsCString with alloc on heap (which we'll steal in a moment)
   temp.SetCapacity(8);          //force temp to have an allocated buffer, even if this is empty.
   PRUnichar* result=temp.mUStr; //steal temp's buffer
   temp.mStr=0;                  //now clear temp's buffer to prevent deallocation

string/obsolete/nsString2.cpp

@@ -719,7 +719,8 @@ nsString* nsString::ToNewString() const {
  */
 char* nsString::ToNewCString() const {
 
-  nsCString temp(*this);  //construct nsCString with alloc on heap (which we'll steal in a moment)
+  nsCString temp;
+  temp.AssignWithConversion(GetUnicode(), Length());  //construct nsCString with alloc on heap (which we'll steal in a moment)
   temp.SetCapacity(8);    //force it to have an allocated buffer, even if this is empty.
   char* result=temp.mStr; //steal temp's buffer
   temp.mStr=0;            //clear temp's buffer to prevent deallocation

xpcom/ds/nsString.cpp

@@ -662,7 +662,8 @@ char* nsCString::ToNewCString() const {
  * @return  ptr to new ascii string
  */
 PRUnichar* nsCString::ToNewUnicode() const {
-  nsString temp(*this);         //construct nsCString with alloc on heap (which we'll steal in a moment)
+  nsString temp;
+  temp.AssignWithConversion(*this);         //construct nsCString with alloc on heap (which we'll steal in a moment)
   temp.SetCapacity(8);          //force temp to have an allocated buffer, even if this is empty.
   PRUnichar* result=temp.mUStr; //steal temp's buffer
   temp.mStr=0;                  //now clear temp's buffer to prevent deallocation

xpcom/ds/nsString2.cpp

@@ -719,7 +719,8 @@ nsString* nsString::ToNewString() const {
  */
 char* nsString::ToNewCString() const {
 
-  nsCString temp(*this);  //construct nsCString with alloc on heap (which we'll steal in a moment)
+  nsCString temp;
+  temp.AssignWithConversion(GetUnicode(), Length());  //construct nsCString with alloc on heap (which we'll steal in a moment)
   temp.SetCapacity(8);    //force it to have an allocated buffer, even if this is empty.
   char* result=temp.mStr; //steal temp's buffer
   temp.mStr=0;            //clear temp's buffer to prevent deallocation

xpcom/string/obsolete/nsString.cpp

@@ -662,7 +662,8 @@ char* nsCString::ToNewCString() const {
  * @return  ptr to new ascii string
  */
 PRUnichar* nsCString::ToNewUnicode() const {
-  nsString temp(*this);         //construct nsCString with alloc on heap (which we'll steal in a moment)
+  nsString temp;
+  temp.AssignWithConversion(*this);         //construct nsCString with alloc on heap (which we'll steal in a moment)
   temp.SetCapacity(8);          //force temp to have an allocated buffer, even if this is empty.
   PRUnichar* result=temp.mUStr; //steal temp's buffer
   temp.mStr=0;                  //now clear temp's buffer to prevent deallocation

xpcom/string/obsolete/nsString2.cpp

@@ -719,7 +719,8 @@ nsString* nsString::ToNewString() const {
  */
 char* nsString::ToNewCString() const {
 
-  nsCString temp(*this);  //construct nsCString with alloc on heap (which we'll steal in a moment)
+  nsCString temp;
+  temp.AssignWithConversion(GetUnicode(), Length());  //construct nsCString with alloc on heap (which we'll steal in a moment)
   temp.SetCapacity(8);    //force it to have an allocated buffer, even if this is empty.
   char* result=temp.mStr; //steal temp's buffer
   temp.mStr=0;            //clear temp's buffer to prevent deallocation