From 9d19b31461d917b1813e9d211c1115e8e722a421 Mon Sep 17 00:00:00 2001 From: Julian Descottes Date: Tue, 17 Apr 2018 11:49:02 +0200 Subject: [PATCH] Bug 1379116 - Localize hardcoded addon installation error string in about:debugging;r=ochameau MozReview-Commit-ID: 1dnaoWrtaSS --HG-- extra : rebase_source : 831989c17ad1041af3e1f9be0b7b10a0805a31cc --- .../client/aboutdebugging/components/addons/InstallError.js | 2 +- devtools/client/locales/en-US/aboutdebugging.properties | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/devtools/client/aboutdebugging/components/addons/InstallError.js b/devtools/client/aboutdebugging/components/addons/InstallError.js index 28c2a51ded70..701fce0c45cc 100644 --- a/devtools/client/aboutdebugging/components/addons/InstallError.js +++ b/devtools/client/aboutdebugging/components/addons/InstallError.js @@ -26,7 +26,7 @@ class AddonsInstallError extends Component { if (!this.props.error) { return null; } - let text = `There was an error during installation: ${this.props.error}`; + let text = Strings.formatStringFromName("addonInstallError", [this.props.error], 1); return dom.div( { className: "addons-install-error" }, dom.span( diff --git a/devtools/client/locales/en-US/aboutdebugging.properties b/devtools/client/locales/en-US/aboutdebugging.properties index 7f9811d61369..7660589d10c4 100644 --- a/devtools/client/locales/en-US/aboutdebugging.properties +++ b/devtools/client/locales/en-US/aboutdebugging.properties @@ -58,6 +58,11 @@ addonDebugging.learnMore = Learn more # load additional add-ons. loadTemporaryAddon = Load Temporary Add-on +# LOCALIZATION NOTE (addonInstallError): +# This string is displayed when an error occurs while installing an addon. +# %S will be replaced with the error message. +addonInstallError = There was an error during installation: %S + # LOCALIZATION NOTE (retryTemporaryInstall): # This string is displayed as a label of a button that allows the user to # retry a failed installation of a temporary add-on.