Bug 1550631 - Include the entryPoint for navigations from about:protections to about:logins. r=jaws

Differential Revision: https://phabricator.services.mozilla.com/D46630

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Matthew Noorenberghe 2019-09-22 15:15:52 +00:00
Родитель 0b4eb51041
Коммит 9e2406cc05
5 изменённых файлов: 14 добавлений и 5 удалений

Просмотреть файл

@ -324,7 +324,9 @@ var AboutProtectionsHandler = {
let win = aMessage.target.browser.ownerGlobal; let win = aMessage.target.browser.ownerGlobal;
switch (aMessage.name) { switch (aMessage.name) {
case "OpenAboutLogins": case "OpenAboutLogins":
win.openTrustedLinkIn("about:logins", "tab"); LoginHelper.openPasswordManager(win, {
entryPoint: "aboutprotections",
});
break; break;
case "OpenContentBlockingPreferences": case "OpenContentBlockingPreferences":
win.openPreferences("privacy-trackingprotection", { win.openPreferences("privacy-trackingprotection", {

Просмотреть файл

@ -43,8 +43,10 @@ export default class MonitorClass {
}); });
let openLockwise = this.doc.getElementById("lockwise-link"); let openLockwise = this.doc.getElementById("lockwise-link");
openLockwise.addEventListener("click", () => { openLockwise.addEventListener("click", evt => {
this.doc.sendTelemetryEvent("click", "lw_open_breach_link"); this.doc.sendTelemetryEvent("click", "lw_open_breach_link");
RPMSendAsyncMessage("OpenAboutLogins");
evt.preventDefault();
}); });
} }

Просмотреть файл

@ -171,7 +171,7 @@
<!-- Display number of exposed stored passwords here. --> <!-- Display number of exposed stored passwords here. -->
</span> </span>
<span id="password-warning"> <span id="password-warning">
<a target="_blank" href="about:logins" id="lockwise-link" data-l10n-name="lockwise-link"></a> <a target="_blank" href="about:logins?entryPoint=aboutprotections" id="lockwise-link" data-l10n-name="lockwise-link"></a>
</span> </span>
</div> </div>
</div> </div>

Просмотреть файл

@ -136,8 +136,13 @@ function waitForTelemetryEventCount(count) {
Ci.nsITelemetry.DATASET_PRERELEASE_CHANNELS, Ci.nsITelemetry.DATASET_PRERELEASE_CHANNELS,
false false
).content; ).content;
if (!events) {
return null;
}
// Ignore irrelevant events from other parts of the browser.
events = events.filter(e => e[1] == "security.ui.protections");
info("got " + (events && events.length) + " events"); info("got " + (events && events.length) + " events");
if (events && events.length == count) { if (events.length == count) {
return events; return events;
} }
return null; return null;

Просмотреть файл

@ -561,7 +561,7 @@ normandy:
pwmgr: pwmgr:
open_management: open_management:
objects: ["autocomplete", "capturedoorhanger", "contextmenu", "direct", "fxamenu", "mainmenu", "pageinfo", "preferences"] objects: ["aboutprotections", "autocomplete", "capturedoorhanger", "contextmenu", "direct", "fxamenu", "mainmenu", "pageinfo", "preferences"]
methods: ["open_management"] methods: ["open_management"]
description: > description: >
Sent when opening the password management UI. Sent when opening the password management UI.