Bug 705654 - Fix uses of uninitialized memory found by valgrind in 632423-1.html. r=joshmoz.

dom/plugins/ipc/PluginInstanceChild.cpp

@@ -3708,6 +3708,7 @@ PluginInstanceChild::AnswerNPP_Destroy(NPError* aResult)
 {
     PLUGIN_LOG_DEBUG_METHOD;
     AssertPluginThread();
+    *aResult = NPERR_NO_ERROR;
 
 #if defined(OS_WIN)
     SetProp(mPluginWindowHWND, kPluginIgnoreSubclassProperty, (HANDLE)1);

dom/plugins/ipc/PluginMessageUtils.cpp

@@ -80,6 +80,22 @@ DeferNPObjectReleaseRunnable::Run()
 namespace mozilla {
 namespace plugins {
 
+NPRemoteWindow::NPRemoteWindow() :
+  window(0), x(0), y(0), width(0), height(0), type(NPWindowTypeDrawable)
+#if defined(MOZ_X11) && defined(XP_UNIX) && !defined(XP_MACOSX)
+  , visualID(0)
+  , colormap(0)
+#endif /* XP_UNIX */
+#if defined(XP_WIN)
+  ,surfaceHandle(0)
+#endif
+{
+  clipRect.top = 0;
+  clipRect.left = 0;
+  clipRect.bottom = 0;
+  clipRect.right = 0;
+}
+
 RPCChannel::RacyRPCPolicy
 MediateRace(const RPCChannel::Message& parent,
             const RPCChannel::Message& child)

dom/plugins/ipc/PluginMessageUtils.h

@@ -110,6 +110,7 @@ typedef nsCString Buffer;
 
 struct NPRemoteWindow
 {
+  NPRemoteWindow();
   uint64_t window;
   int32_t x;
   int32_t y;