Bug 1305075 - Stop shipping filepicker.css and filepicker.xul on Mac and Windows, r=Gijs.

testing/firefox-ui/tests/puppeteer/test_l10n.py

@@ -19,7 +19,7 @@ class TestL10n(FirefoxTestCase):
         FirefoxTestCase.tearDown(self)
 
     def test_dtd_entity_chrome(self):
-        dtds = ['chrome://global/locale/filepicker.dtd',
+        dtds = ['chrome://global/locale/about.dtd',
                 'chrome://browser/locale/baseMenuOverlay.dtd']
 
         value = self.l10n.get_entity(dtds, 'helpSafeMode.label')
@@ -29,7 +29,7 @@ class TestL10n(FirefoxTestCase):
         self.assertRaises(MarionetteException, self.l10n.get_entity, dtds, 'notExistent')
 
     def test_dtd_entity_content(self):
-        dtds = ['chrome://global/locale/filepicker.dtd',
+        dtds = ['chrome://global/locale/about.dtd',
                 'chrome://global/locale/aboutSupport.dtd']
 
         value = self.l10n.get_entity(dtds, 'aboutSupport.pageTitle')

toolkit/components/filepicker/moz.build

@@ -4,24 +4,22 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
-if CONFIG['MOZ_XUL'] and \
-    CONFIG['MOZ_WIDGET_TOOLKIT'] not in ('android', 'cocoa', 'windows'):
-        XPIDL_MODULE = 'filepicker'
-        XPIDL_SOURCES += [
-            'nsIFileView.idl',
-        ]
-        SOURCES += [
-            'nsFileView.cpp',
-        ]
-        EXTRA_COMPONENTS += [
-            'nsFilePicker.js',
-        ]
-        EXTRA_PP_COMPONENTS += [
-            'nsFilePicker.manifest',
-        ]
-        XPCSHELL_TESTS_MANIFESTS += [
-            'test/unit/xpcshell.ini',
-        ]
-        FINAL_LIBRARY = 'xul'
+XPIDL_MODULE = 'filepicker'
+XPIDL_SOURCES += [
+    'nsIFileView.idl',
+]
+SOURCES += [
+    'nsFileView.cpp',
+]
+EXTRA_COMPONENTS += [
+    'nsFilePicker.js',
+]
+EXTRA_PP_COMPONENTS += [
+    'nsFilePicker.manifest',
+]
+XPCSHELL_TESTS_MANIFESTS += [
+    'test/unit/xpcshell.ini',
+]
+FINAL_LIBRARY = 'xul'
 
 JAR_MANIFESTS += ['jar.mn']

toolkit/components/moz.build

@@ -26,7 +26,6 @@ DIRS += [
     'downloads',
     'extensions',
     'exthelper',
-    'filepicker',
     'filewatcher',
     'finalizationwitness',
     'formautofill',
@@ -88,6 +87,9 @@ if CONFIG['MOZ_FEEDS']:
 if CONFIG['MOZ_XUL']:
     DIRS += ['autocomplete', 'satchel']
 
+if 'gtk' in CONFIG['MOZ_WIDGET_TOOLKIT']:
+    DIRS += ['filepicker']
+
 if CONFIG['MOZ_TOOLKIT_SEARCH']:
     DIRS += ['search']
 

toolkit/locales/jar.mn

@@ -46,7 +46,9 @@
   locale/@AB_CD@/global/extensions.properties           (%chrome/global/extensions.properties)
   locale/@AB_CD@/global/fallbackMenubar.properties      (%chrome/global/fallbackMenubar.properties)
   locale/@AB_CD@/global/filefield.properties            (%chrome/global/filefield.properties)
+#ifdef MOZ_GTK
   locale/@AB_CD@/global/filepicker.dtd                  (%chrome/global/filepicker.dtd)
+#endif
   locale/@AB_CD@/global/filepicker.properties           (%chrome/global/filepicker.properties)
 #ifndef MOZ_FENNEC
   locale/@AB_CD@/global/findbar.dtd                     (%chrome/global/findbar.dtd)

toolkit/locales/moz.build

@@ -7,4 +7,7 @@
 if CONFIG['MOZ_BUILD_APP'] == 'mobile/android':
   DEFINES['MOZ_FENNEC'] = True
 
+if 'gtk' in CONFIG['MOZ_WIDGET_TOOLKIT']:
+  DEFINES['MOZ_GTK'] = True
+
 JAR_MANIFESTS += ['jar.mn']

toolkit/themes/osx/global/filepicker.css

@@ -1,40 +0,0 @@
-/* This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
-
-@import url("chrome://global/skin/");
-
-@namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");
-
-/* ::::: column widths ::::: */
-
-#FilenameColumn,
-#ContentLengthColumn,
-#LastModifiedDateColumn {
-  width: 100px;
-}
-
-/* ::::: file/directory items ::::: */
-
-treechildren::-moz-tree-image(treecolAutoCompleteValue, directory),
-treechildren::-moz-tree-image(FilenameColumn, directory) {
-  margin-right: 2px;
-  list-style-image: url("chrome://global/skin/filepicker/dir-closed.gif");
-}
-
-treechildren::-moz-tree-image(treecolAutoCompleteValue, file),
-treechildren::-moz-tree-image(FilenameColumn, file) {
-  list-style-image: url("chrome://global/skin/filepicker/blank.gif");
-}
-
-/* ::::: button items ::::: */
-
-.up-button {
-  list-style-image: url("chrome://global/skin/filepicker/folder-up.gif");
-  max-width: 36px;
-}
-
-.home-button {
-  list-style-image: url("chrome://global/skin/filepicker/folder-home.gif");
-  max-width: 36px;
-}

toolkit/themes/osx/global/jar.mn

@@ -17,7 +17,6 @@ toolkit.jar:
   skin/classic/global/dialog.css
   skin/classic/global/dropmarker.css
   skin/classic/global/filefield.css
-  skin/classic/global/filepicker.css
   skin/classic/global/filters.svg
 * skin/classic/global/findBar.css
 * skin/classic/global/global.css

toolkit/themes/windows/global/filepicker.css

@@ -1,77 +0,0 @@
-/* This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
-
-/* ===== filepicker.css =================================================
-  == Styles used by the File Picker dialog.
-  ======================================================================= */
-
-@import url("chrome://global/skin/");
-
-@namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");
-
-/* ::::: column widths ::::: */
-
-#FilenameColumn,
-#ContentLengthColumn,
-#LastModifiedDateColumn {
-  width: 100px;
-}
-
-/* ::::: file/directory items ::::: */
-
-treechildren::-moz-tree-image(treecolAutoCompleteValue, directory),
-treechildren::-moz-tree-image(FilenameColumn, directory) {
-  list-style-image: url("chrome://global/skin/icons/folder-item.png");
-  -moz-image-region: rect(0px, 32px, 16px, 16px);
-}
-
-treechildren::-moz-tree-image(treecolAutoCompleteValue, file),
-treechildren::-moz-tree-image(FilenameColumn, file) {
-  list-style-image: url("chrome://global/skin/icons/folder-item.png");
-  -moz-image-region: rect(16px, 16px, 32px, 0px);
-}
-
-/* ::::: button items ::::: */
-
-/* up-button */
-
-.up-button {
-  list-style-image: url("chrome://global/skin/Filepicker.png");
-  -moz-image-region: rect(0px 24px 24px 0px);
-  max-width: 36px;
-}
-
-.up-button:hover {
-  list-style-image: url("chrome://global/skin/Filepicker.png");
-  -moz-image-region: rect(24px 24px 48px 0px);
-  max-width: 36px;
-}
-
-/* home-button */
-
-.home-button {
-  list-style-image: url("chrome://global/skin/Filepicker.png");
-  -moz-image-region: rect(0px 48px 24px 24px);
-  max-width: 36px;
-}
-
-.home-button:hover {
-  list-style-image: url("chrome://global/skin/Filepicker.png");
-  -moz-image-region: rect(24px 48px 48px 24px);
-  max-width: 36px;
-}
-
-/* new-dir-button */
-
-.new-dir-button {
-  list-style-image: url("chrome://global/skin/Filepicker.png");
-  -moz-image-region: rect(0px 72px 24px 48px);
-  max-width: 36px;
-}
-
-.new-dir-button:hover {
-  list-style-image: url("chrome://global/skin/Filepicker.png");
-  -moz-image-region: rect(24px 72px 48px 48px);
-  max-width: 36px;
-}

toolkit/themes/windows/global/jar.mn

@@ -20,8 +20,6 @@ toolkit.jar:
 #endif
   skin/classic/global/colorpicker.css
   skin/classic/global/commonDialog.css
-  skin/classic/global/filepicker.css
-  skin/classic/global/Filepicker.png                       (filepicker/Filepicker.png)
   skin/classic/global/findBar.css
 * skin/classic/global/global.css
   skin/classic/global/listbox.css