From 9eb3d192778e40d9e666be45ff35c33978020280 Mon Sep 17 00:00:00 2001
From: Mike Conley <mconley@mozilla.com>
Date: Thu, 30 Nov 2017 15:15:10 -0500
Subject: [PATCH] Bug 888784 - Make FormHistory.search use Sqlite.jsm database
 backend. r=mak

MozReview-Commit-ID: J1ElTJpWHza

--HG--
extra : rebase_source : 3568f430594adcd72bdcd7750ef86bf17f2441dd
---
 toolkit/components/satchel/FormHistory.jsm | 73 +++++++++++++---------
 1 file changed, 42 insertions(+), 31 deletions(-)

diff --git a/toolkit/components/satchel/FormHistory.jsm b/toolkit/components/satchel/FormHistory.jsm
index 10d297dda5ea..825dc019ca8b 100644
--- a/toolkit/components/satchel/FormHistory.jsm
+++ b/toolkit/components/satchel/FormHistory.jsm
@@ -1088,47 +1088,58 @@ this.FormHistory = {
     return defaultHandlers;
   },
 
-  search(aSelectTerms, aSearchData, aCallbacks) {
+  search(aSelectTerms, aSearchData, aRowFuncOrHandlers) {
     // if no terms selected, select everything
     if (!aSelectTerms) {
       aSelectTerms = validFields;
     }
     validateSearchData(aSearchData, "Search");
 
-    let stmt = makeSearchStatement(aSearchData, aSelectTerms);
+    let query = "SELECT " + aSelectTerms.join(", ") + " FROM moz_formhistory";
+    let queryTerms = makeQueryPredicates(aSearchData);
+    if (queryTerms) {
+      query += " WHERE " + queryTerms;
+    }
 
-    let handlers = {
-      handleResult(aResultSet) {
-        for (let row = aResultSet.getNextRow(); row; row = aResultSet.getNextRow()) {
-          let result = {};
-          for (let field of aSelectTerms) {
-            result[field] = row.getResultByName(field);
+    let handlers;
+
+    if (typeof aRowFuncOrHandlers == "function") {
+      handlers = this._prepareHandlers();
+      handlers.handleResult = aRowFuncOrHandlers;
+    } else if (typeof aRowFuncOrHandlers == "object") {
+      handlers = this._prepareHandlers(aRowFuncOrHandlers);
+    }
+
+    let allResults = [];
+
+    return new Promise((resolve, reject) => {
+      this.db.then(async conn => {
+        try {
+          await conn.executeCached(query, aSearchData, row => {
+            let result = {};
+            for (let field of aSelectTerms) {
+              result[field] = row.getResultByName(field);
+            }
+
+            if (handlers) {
+              handlers.handleResult(result);
+            } else {
+              allResults.push(result);
+            }
+          });
+          if (handlers) {
+            handlers.handleCompletion(0);
           }
-
-          if (aCallbacks && aCallbacks.handleResult) {
-            aCallbacks.handleResult(result);
+          resolve(allResults);
+        } catch (e) {
+          if (handlers) {
+            handlers.handleError(e);
+            handlers.handleCompletion(1);
           }
+          reject(e);
         }
-      },
-
-      handleError(aError) {
-        if (aCallbacks && aCallbacks.handleError) {
-          aCallbacks.handleError(aError);
-        }
-      },
-
-      handleCompletion(aReason) {
-        if (aCallbacks && aCallbacks.handleCompletion) {
-          aCallbacks.handleCompletion(
-            aReason == Ci.mozIStorageStatementCallback.REASON_FINISHED ?
-              0 :
-              1
-          );
-        }
-      },
-    };
-
-    stmt.executeAsync(handlers);
+      });
+    });
   },
 
   count(aSearchData, aHandlers) {