Bug 1830102: Fix warning and reenable warnings as errors for remotesandboxbroker. r=handyman

Differential Revision: https://phabricator.services.mozilla.com/D177769

security/sandbox/win/src/remotesandboxbroker/moz.build

@@ -25,9 +25,6 @@ for var in ("UNICODE", "_UNICODE"):
 
 FINAL_LIBRARY = "xul"
 
-if CONFIG["CC_TYPE"] == "clang-cl":
-    AllowCompilerWarnings()  # workaround for bug 1090497
-
 IPDL_SOURCES += ["PRemoteSandboxBroker.ipdl"]
 
 include("/ipc/chromium/chromium-config.mozbuild")

security/sandbox/win/src/remotesandboxbroker/remoteSandboxBroker.cpp

@@ -13,7 +13,7 @@
 namespace mozilla {
 
 RemoteSandboxBroker::RemoteSandboxBroker(uint32_t aLaunchArch)
-    : mLaunchArch(aLaunchArch), mParent(new RemoteSandboxBrokerParent) {}
+    : mParent(new RemoteSandboxBrokerParent), mLaunchArch(aLaunchArch) {}
 
 RemoteSandboxBroker::~RemoteSandboxBroker() {
   MOZ_ASSERT(