Bug 1343043 - Part 1: Remove some global variables from shell.js and instead declare them locally in tests. r=shu

js/src/tests/Intl/NumberFormat/significantDigitsOfZero.js

@@ -25,7 +25,9 @@ for (var i = 0; i < testData.length; i++) {
     var max = testData[i].maximumSignificantDigits;
     var options = {minimumSignificantDigits: min, maximumSignificantDigits: max};
     var format = new Intl.NumberFormat("en-US", options);
-    assertEq(format.format(0), testData[i].expected,
+    var actual = format.format(0);
+    var expected = testData[i].expected;
+    assertEq(actual, expected,
              "Wrong formatted string for 0 with " +
              "minimumSignificantDigits " + min +
              ", maximumSignificantDigits " + max +

js/src/tests/ecma_6/Comprehensions/error-messages.js

@@ -130,6 +130,8 @@ function inFun(str) { return '(function(){' + str + '})' }
 function inGen(str) { return '(function*(){' + str + '})' }
 function inGenExp(str) { return '(for (y of ' + str + ') y)' }
 
+var summary = '';
+
 function test()
 {
   enterFunc ('test');

js/src/tests/ecma_6/Generators/shell.js

@@ -4,7 +4,7 @@
 
 function assertFalse(a) { assertEq(a, false) }
 function assertTrue(a) { assertEq(a, true) }
-function assertNotEq(found, not_expected) { assertFalse(found === expected) }
+function assertNotEq(found, not_expected) { assertEq(Object.is(found, not_expected), false) }
 function assertIteratorResult(result, value, done) {
     assertDeepEq(result.value, value);
     assertEq(result.done, done);

js/src/tests/ecma_7/TypedObject/atopbuffer.js

@@ -1,5 +1,6 @@
 // |reftest| skip-if(!this.hasOwnProperty("TypedObject"))
 var BUGNUMBER = 898356;
+var summary = "";
 
 var {StructType, uint32, Object, Any, storage, objectType} = TypedObject;
 

js/src/tests/ecma_7/TypedObject/atopbufferwithoffset.js

@@ -1,5 +1,6 @@
 // |reftest| skip-if(!this.hasOwnProperty("TypedObject"))
 var BUGNUMBER = 898356;
+var summary = "";
 
 var {StructType, uint32, Object, Any, storage, objectType} = TypedObject;
 

js/src/tests/ecma_7/TypedObject/storageopaque.js

@@ -1,5 +1,6 @@
 // |reftest| skip-if(!this.hasOwnProperty("TypedObject"))
 var BUGNUMBER = 898356;
+var summary = "";
 
 var {StructType, uint32, Object, Any, storage, objectType} = TypedObject;
 

js/src/tests/js1_7/regress/regress-414553.js

@@ -5,6 +5,8 @@
 
 //-----------------------------------------------------------------------------
 var BUGNUMBER = 414553;
+var summary = '';
+
 printBugNumber(BUGNUMBER);
 printStatus(summary);
 

js/src/tests/js1_8_5/regress/regress-355569.js

@@ -7,6 +7,7 @@
 var bug = 355569;
 var actual = '';
 var expect = '';
+var summary = '';
 
 printBugNumber (bug);
 printStatus (summary);

js/src/tests/shell.js

@@ -794,11 +794,6 @@ var gFailureExpected = false;
 
 var gTestcases = new Array();
 var gTc = gTestcases.length;
-var summary = '';
-var description = '';
-var expected = '';
-var actual = '';
-var msg = '';
 
 /*
  * constant strings