зеркало из https://github.com/mozilla/gecko-dev.git
Bug 1381577 - Part E; Add assertion that there is no space in each action or option passed to mozharness tests. r=dustin
Land date changes to support windows nightlies onto central This is needed because on Linux these arrays are joined by a space then passed to the shell as 'for foo in $bar' which will treat spaces as valid delimiters, whereas for windows workers the structure is evaluated completely in python, which means a single value with spaces won't generate the correct command output. Enforcing this prevents mistakes with yaml syntax going unnoticed. MozReview-Commit-ID: 3U4orzyiBuf --HG-- extra : rebase_source : 6fb7671f70d2169225d36c0c728324b01b3f055a
This commit is contained in:
Родитель
02dcc45d35
Коммит
a0984702f3
|
@ -242,9 +242,11 @@ def mozharness_on_generic_worker(config, job, taskdesc):
|
|||
mh_command.append(r'--skip-buildbot-actions')
|
||||
mh_command.append(r'--work-dir %cd:Z:=z:%\build')
|
||||
for action in run.get('actions', []):
|
||||
assert ' ' not in action
|
||||
mh_command.append('--' + action)
|
||||
|
||||
for option in run.get('options', []):
|
||||
assert ' ' not in option
|
||||
mh_command.append('--' + option)
|
||||
if run.get('custom-build-variant-cfg'):
|
||||
mh_command.append('--custom-build-variant')
|
||||
|
|
Загрузка…
Ссылка в новой задаче