Bug 1261123 - don't needlessly construct nsAutoCString temporaries in nsDefaultURIFixup; r=smaug

We can make the non-virtual overload of IsDomainWhitelisted take an
nsACString instead of an nsAutoCString and avoid some unnecessary
copying.

docshell/base/nsDefaultURIFixup.cpp

@@ -1071,7 +1071,7 @@ nsDefaultURIFixup::KeywordURIFixup(const nsACString& aURIString,
 }
 
 bool
-nsDefaultURIFixup::IsDomainWhitelisted(const nsAutoCString aAsciiHost,
+nsDefaultURIFixup::IsDomainWhitelisted(const nsACString& aAsciiHost,
                                        const uint32_t aDotLoc)
 {
   if (sDNSFirstForSingleWords) {
@@ -1098,7 +1098,7 @@ nsDefaultURIFixup::IsDomainWhitelisted(const nsACString& aDomain,
                                        const uint32_t aDotLoc,
                                        bool* aResult)
 {
-  *aResult = IsDomainWhitelisted(nsAutoCString(aDomain), aDotLoc);
+  *aResult = IsDomainWhitelisted(aDomain, aDotLoc);
   return NS_OK;
 }
 

docshell/base/nsDefaultURIFixup.h

@@ -40,7 +40,7 @@ private:
   bool PossiblyHostPortUrl(const nsACString& aUrl);
   bool MakeAlternateURI(nsIURI* aURI);
   bool IsLikelyFTP(const nsCString& aHostSpec);
-  bool IsDomainWhitelisted(const nsAutoCString aAsciiHost,
+  bool IsDomainWhitelisted(const nsACString& aAsciiHost,
                            const uint32_t aDotLoc);
 };