From a17751eb93d7f160fb43859f120023c59b49f170 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= Date: Thu, 14 Jun 2018 10:08:37 -0700 Subject: [PATCH] No bug - re-use the mode_to_origin function. r=me MozReview-Commit-ID: AcDR6KcrbWI --- servo/ports/geckolib/glue.rs | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/servo/ports/geckolib/glue.rs b/servo/ports/geckolib/glue.rs index 82b6d4dca953..e46470e6e119 100644 --- a/servo/ports/geckolib/glue.rs +++ b/servo/ports/geckolib/glue.rs @@ -1134,15 +1134,19 @@ pub extern "C" fn Servo_Element_IsPrimaryStyleReusedViaRuleNode(element: RawGeck data.flags.contains(data::ElementDataFlags::PRIMARY_STYLE_REUSED_VIA_RULE_NODE) } -#[no_mangle] -pub extern "C" fn Servo_StyleSheet_Empty(mode: SheetParsingMode) -> RawServoStyleSheetContentsStrong { - let global_style_data = &*GLOBAL_STYLE_DATA; - let origin = match mode { +fn mode_to_origin(mode: SheetParsingMode) -> Origin { + match mode { SheetParsingMode::eAuthorSheetFeatures => Origin::Author, SheetParsingMode::eUserSheetFeatures => Origin::User, SheetParsingMode::eAgentSheetFeatures => Origin::UserAgent, SheetParsingMode::eSafeAgentSheetFeatures => Origin::UserAgent, - }; + } +} + +#[no_mangle] +pub extern "C" fn Servo_StyleSheet_Empty(mode: SheetParsingMode) -> RawServoStyleSheetContentsStrong { + let global_style_data = &*GLOBAL_STYLE_DATA; + let origin = mode_to_origin(mode); let shared_lock = &global_style_data.shared_lock; Arc::new( StylesheetContents::from_str( @@ -1158,15 +1162,6 @@ pub extern "C" fn Servo_StyleSheet_Empty(mode: SheetParsingMode) -> RawServoStyl ).into_strong() } -fn mode_to_origin(mode: SheetParsingMode) -> Origin { - match mode { - SheetParsingMode::eAuthorSheetFeatures => Origin::Author, - SheetParsingMode::eUserSheetFeatures => Origin::User, - SheetParsingMode::eAgentSheetFeatures => Origin::UserAgent, - SheetParsingMode::eSafeAgentSheetFeatures => Origin::UserAgent, - } -} - /// Note: The load_data corresponds to this sheet, and is passed as the parent /// load data for child sheet loads. It may be null for certain cases where we /// know we won't have child loads.